[GitHub] nifi issue #2140: NIFI-3950 Refactor AWS bundle

2017-10-19 Thread christophercurrie
Github user christophercurrie commented on the issue: https://github.com/apache/nifi/pull/2140 Ok, I've added those files. Let me know if they look OK and if there's anything else that needs doing. ---

[GitHub] nifi issue #2140: NIFI-3950 Refactor AWS bundle

2017-10-17 Thread christophercurrie
Github user christophercurrie commented on the issue: https://github.com/apache/nifi/pull/2140 Yes, though I'm not sure what action items are left for me at this point. ---

[GitHub] nifi issue #2140: NIFI-3950 Refactor AWS bundle

2017-09-15 Thread christophercurrie
Github user christophercurrie commented on the issue: https://github.com/apache/nifi/pull/2140 @jvwing I have pushed a commit that removes all unnecessary changes from the PR. Sorry for the delay. ---

[GitHub] nifi issue #2140: NIFI-3950 Refactor AWS bundle

2017-09-12 Thread christophercurrie
Github user christophercurrie commented on the issue: https://github.com/apache/nifi/pull/2140 Not a problem on the reverts. The original instructions asked for a squashed commit. Should I create a new smaller PR, or add the revert commit to this one? ---

[GitHub] nifi issue #2140: NIFI-3950 Refactor AWS bundle

2017-09-11 Thread christophercurrie
Github user christophercurrie commented on the issue: https://github.com/apache/nifi/pull/2140 How smooth their experience will be will probably depend upon their internal project practices. Since the `nifi-aws-processors` package would have been a required dependency for such custom

[GitHub] nifi pull request #2140: NIFI-3950 Refactor AWS bundle

2017-09-11 Thread christophercurrie
Github user christophercurrie commented on a diff in the pull request: https://github.com/apache/nifi/pull/2140#discussion_r138257973 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-nar/pom.xml --- @@ -32,13 +32,14 @@ org.apache.nifi

[GitHub] nifi pull request #2140: NIFI-3950 Refactor AWS bundle

2017-09-11 Thread christophercurrie
Github user christophercurrie commented on a diff in the pull request: https://github.com/apache/nifi/pull/2140#discussion_r138257661 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -253,11 +253,6

[GitHub] nifi pull request #2140: NIFI-3950 Refactor AWS bundle

2017-09-11 Thread christophercurrie
Github user christophercurrie commented on a diff in the pull request: https://github.com/apache/nifi/pull/2140#discussion_r138257624 --- Diff: pom.xml --- @@ -1109,12 +1109,6 @@ org.apache.nifi -nifi-kudu

[GitHub] nifi pull request #2140: NIFI-3950 Refactor AWS bundle

2017-09-11 Thread christophercurrie
Github user christophercurrie commented on a diff in the pull request: https://github.com/apache/nifi/pull/2140#discussion_r138257582 --- Diff: nifi-assembly/pom.xml --- @@ -1,13 +1,13 @@ -

[GitHub] nifi issue #2140: NIFI-3950 Refactor AWS bundle

2017-09-11 Thread christophercurrie
Github user christophercurrie commented on the issue: https://github.com/apache/nifi/pull/2140 The failed CI builds seem to be failing for other PRs and do not appear to be caused by this change. ---

[GitHub] nifi pull request #2140: NIFI-3950 Refactor AWS bundle

2017-09-10 Thread christophercurrie
GitHub user christophercurrie opened a pull request: https://github.com/apache/nifi/pull/2140 NIFI-3950 Refactor AWS bundle This PR provides a separate NAR for the `AWSCredentialsProviderService` API, and a new `nifi-aws-abstract-processors` jar so that custom processors can take