GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/2399
NIFI-4748 Add endpoint override to Kinesis processors
Note that for some mock Kinesis implementations you have to disable CBOR;
this can be done by setting the environment variable AWS_CBOR_DISABLE
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2308
FWIW, the tests pass on the following build as well:
```sh
$ mvn clean install -Dhadoop.version=2.8.2 -Dhadoop.guava.version=12.0.1
-Dhadoop.http.client.version=4.5.2
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/2308
NIFI-4650 Added independent hadoop.http.core.version property
For later releases of HttpComponents HttpClient and HttpCore versioning
diverges so these need to be separate properties to support
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2293
@joewitt I don't think so. If we get NIFI-4650 in, then we can probably
support builds against 2.8.x, 2.9.x, etc. on official releases without
introducing more deps to PutParquet.
@baank I
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2293
@baank So, we still wouldn't need to update the Hadoop version on
everything yet, because in principle you can just do a build of NiFi overriding
the hadoop.version property and use 2.8.x
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2293
@baank Definitely thanks for the contrib, but unfortunately I don't think
this is the right solution/it supports S3 without any code changes.
PutParquet provides an "Additional Clas
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/2302
NIFI-4640 Sub source w/ . in nifi.sh to be POSIX compliant
Tested against official Docker image (based on Debian stretch), Amazon
Linux, and OS X (which doesn't run that part of the script anyway
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2301
Forgot JIRA issue # so closing and re-opening to force link to JIRA.
---
Github user jfrazee closed the pull request at:
https://github.com/apache/nifi/pull/2301
---
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/2301
Sub source w/ . in nifi.sh to be POSIX compliant
Tested against official Docker image (based on Debian stretch), Amazon
Linux, and OS X (which doesn't run that part of the script anyway).
You can
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2155
LGTM +1
Successfully ran build w/ -Pcontrib-check and tested image w/ `docker run
-it -p 8080:8080 apache/nifi:latest`
---
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r153055354
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r152583250
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2155
Reviewing for once
---
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1969
@pvillard31 I think this needs more updates to the tests. Since you've
added URI, collection, and DB, we should probably add that to the Get test.
And, I think there are similar changes that make
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1969#discussion_r127808068
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
---
@@ -59,14 +59,21
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1969
@pvillard31 I think we can add EL to collection without having to do
anything fancy since getCollection() in AbstractMongoProcessor re-uses the
mongoClient already.
That said, is it worth
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1953
@pvillard31 It seems like we should just use LookupAttribute for this use
case. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1696
@trixpan I think there's a mistake in the last line of .gitattributes. It
is missing the 'text' qualifier and just is the file pattern and then eol. Let
me know if I've misunderstood; otherwise I'll
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1934
@NielsZeilemaker I looked at this and that was exactly my concern as well
and I think your suggestion of inverting the change to make the rejection WARN
is a good one. You get the control over
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
@alopresto +1 will open another JIRA for covering the rest of the problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1794
@trixpan LGTM +1 and I tested on SuSE and not SuSE.
You can go ahead and merge it or I can in my afternoon/your evening.
---
If your project is set up for it, you can reply to this email
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
@alopresto Welp, TestGetFile has similar problems. This one LGTM so
question is whether we want to merge this one or expand the scope; thoughts?
---
If your project is set up for it, you can reply
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1865#discussion_r118769414
--- Diff:
nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy
---
@@ -88,6 +88,11 @@ class
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
@alopresto I was expecting to see System.getProperty("user.name") used
instead of the exec. But I'm a little naive about what the drawback could be;
maybe because you coul
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1856
This was a +1 btw, obviously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1830
Superseded by #1856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jfrazee closed the pull request at:
https://github.com/apache/nifi/pull/1830
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1858
NIFI-3978 Increase threadpool size for S2S HTTP tests
Increases threadpool limits for S2S HTTP tests so they'll pass on many core
machines, as discussed in
[NIFI-3978](https://issues.apache.org
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1794
@trixpan Yep, it's working. Is there any use in using the ID_LIKE variable
instead of ID? If so we could change that up quick, else I think this is good
to go.
---
If your project is set up
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1794
@trixpan Fair enough. Seems clear the lsb_release suggestion was bad. BTW,
I tested your changes on opensuse:latest (leap) and it's working as expected.
---
If your project is set up for it, you can
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1830#discussion_r118408976
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1830
@ijokarumawak The changes from
[NIFI-3339](https://issues.apache.org/jira/browse/NIFI-3339)/#1450 have been
removed from this PR along with the DatabaseLookupService. Will re-submit that
stuff
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1830#discussion_r118341314
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LookupAttribute.java
---
@@ -0,0
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1794
@trixpan @apiri Few things. It seems like we should be using lsb_release to
grab the OS as well as chkconfig to handle creating run level symlinks instead
of on on our own, at least for most
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1830#discussion_r117810505
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1830#discussion_r117809682
--- Diff:
nifi-nar-bundles/nifi-lookup-bundle/nifi-lookup-processors/src/main/java/org/apache/nifi/processors/lookup/LookupAttribute.java
---
@@ -0,0 +1,226
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1830#discussion_r117809657
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-service-api/src/main/java/org/apache/nifi/lookup/LookupService.java
---
@@ -17,25 +17,47
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1830
@ijokarumawak FYI, I think we need to make sure we see what happens to
[NIFI-3946](https://issues.apache.org/jira/browse/NIFI-3946)/#1833 before we
merge this. By all means start having a look though
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1833#discussion_r117601695
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1833#discussion_r117601703
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/maxmind
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1830
NIFI-3404 Add lookup processor for enrichments/joins to reference data
Note: This is overlaid on
[NIFI-3339](https://issues.apache.org/jira/browse/NIFI-3339)/#1450.
You can merge this pull request
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1809
With this FreeFormTextRecordSetWriter enables correctly now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1807#discussion_r116796084
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1763
NIFI-3815 Fix build RPM using mvn install -Prpm,generateArchives
Note that GPG signing may not work with certain combinations of the Maven
plugin, GPG and RPM build tools [1].
1. https
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1696
@trixpan Do you know which files are problematic? I'm assuming the *.txt;
i.e., the content that's being encrypted. I'd figure it wouldn't matter for the
*.asc and *.pgp.
---
If your project is set
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1731
NIFI-3771 Move HL7 test docs into class members to avoid git rewriting CRs
See also [NIFI-1655](https://issues.apache.org/jira/browse/NIFI-1655) and
#1696
You can merge this pull request
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1696
@trixpan You're right about the HL7 and it's actually ill-formed if you
don't use CR, crazy. For best results, though, we should just move the HL7
content into a String in the test class. Renaming
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1015
@trixpan Just rebased it again. Made some minor changes: using
MD5SumMonitor with the watcher now because the last modified monitor wasn't
reliably testable, setting the check schedule to 0 disables
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1663
NIFI-3692 Use hbc-core instead of hbc-twitter4j in social-media bundle to
resolve org.json cat-x
Note: We can't remove Twitter4j from nifi-assembly/NOTICE until
[NIFI-3018](https
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale +1 will merge in the morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1625
@apiri Oh, I see now. You're saying move the one in `script` to
`before_cache`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1625
@apiri I think there might be two tasks here to make sure everything is
copacetic: (1) remove that part of the tree so we don't bother caching
it/downloading it period and (2) removing it before
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1584
@mattyb149 Ok LGTM now so +1
I tested with
[NIFI-3585.xml](https://gist.github.com/jfrazee/63fc76f25bc5cdcfaf66d246cf232d19)
on an Amazon RDS SQL Server instance using the Orders table
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1584
@mattyb149 I think I'll be able to say LGTM if this `orderByClause` thing
gets fixed. Right now I think it only works on tables where the max value
column is ID.
---
If your project is set up
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1584#discussion_r105506187
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/MSSQL2008DatabaseAdapter.java
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/854
@joewitt It's rebased against master again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1290
@klinvill Do you know what version of NiFi you were running against? The
NumberFormatException error was fixed in 1.1.0 by
[NIFI-2887](https://issues.apache.org/jira/browse/NIFI-2887) and a relevant
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale We're getting pretty close. In addition to the per-line
comments I noticed that you have DOS-style CRLF endings. Can you changes these
to newlines only using dos2unix or something
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r104681870
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/resources/docs/org.apache.nifi.processors.ccda.ExtractCCDAAttributes
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r104681504
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,329
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r104681331
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,329
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r104681118
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,329
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r104680946
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-nar/src/main/resources/META-INF/LICENSE
---
@@ -0,0 +1,238
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale I left some comments on some things that we need to change.
Most are small but important modifications, but there's one thing that after
some thought I think the processor is doing
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102510825
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,383
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102509370
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,383
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102500181
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,383
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102493388
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,383
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102492802
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,383
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102486355
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/java/org/apache/nifi/processors/ccda/ExtractCCDAAttributes.java
---
@@ -0,0 +1,383
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1312#discussion_r102478735
--- Diff:
nifi-nar-bundles/nifi-ccda-bundle/nifi-ccda-processors/src/main/resources/docs/org.apache.nifi.processors.ccda.ExtractCCDAAttributes
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale Fantastic. Will start digging into the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale Thanks for the explanation. I just wanted to make sure we
discussed the packaging. The XML file is potentially an issue though. Even if
it's an open license, without knowing what
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1422
LGTM +1
Verified builds on Amazon Linux w/ and w/o -Prpm and checked rpm vs. tar.gz
and .zip installs to verify correct bootstrap.conf.
---
If your project is set up for it, you can reply
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1312
@kedarchitale I'm going to try picking up the review on this so we can get
this done. Thanks for already making all the changes Joe suggested!
I have two questions now. First, do you think
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1422#discussion_r96983531
--- Diff: nifi-assembly/pom.xml ---
@@ -19,6 +19,10 @@ language governing permissions and limitations under the
License. -->
nifi-assem
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1422#discussion_r96313139
--- Diff: nifi-assembly/pom.xml ---
@@ -19,6 +19,10 @@ language governing permissions and limitations under the
License. -->
nifi-assem
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1422#discussion_r96305976
--- Diff: nifi-assembly/pom.xml ---
@@ -19,6 +19,10 @@ language governing permissions and limitations under the
License. -->
nifi-assem
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1422
@trixpan Starting review of this right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1273
NIFI-3104 Remove MPL-licensed test data from TestExtractHL7Attributes
This PR removes the offending tests and updates relevant NOTICE files to
remove, now irrelevant, notices.
- [X
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1198
@fidget83 I think the right thing is to find some way to update the run.as
setting, as @trixpan mentions, from the rpm since we know the nifi user exists
then and fold that into the rpm spec. Right
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1250
NIFI-3061 PutAzureEventHub blocks after network interruption
This change maintains status quo and does not enable the existing unit
tests. The change was tested against
[NIFI-3061.xml](https
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/854
@trixpan I'll be getting back to this today. There was a bug fix that had
to slide in before this too so it's not going to rebase cleanly anymore.
---
If your project is set up for it, you can reply
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1123
NIFI-2887 NumberFormatException in HL7ExtractAttributes for repeating
segments with order control codes
Fixes NIFI-2887 and adds more test cases
You can merge this pull request into a Git
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1026
Closing in favor of #1027 which includes the properties enhancement too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jfrazee closed the pull request at:
https://github.com/apache/nifi/pull/1026
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1027
NIFI-2790 Set JMS destination name on send/receive instead of using the
default destination
Note: This was branched off of NIFI-2789 / #1026.
You can merge this pull request into a Git repository
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1015
NIFI-2767 Periodically reload properties from file-based variable registry
properties files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/854
NIFI-2564 Add support for HL7 composite component names
Wanted to start getting some feedback on this.
ExtractHL7Attributes can currently parse composite components, e.g., output
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/609
@JPercivall Addressed your latest comments and added a test with the cache
disabled since the logic varies depending on that value now.
---
If your project is set up for it, you can reply
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/609
1. @JPercivall I addressed all your comments above and added a template to
https://gist.github.com/jfrazee/a501336826aa77d0daa74e8e0aa3afd0.
2. There is one change in behavior now -- a cache size
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/609#discussion_r71950397
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -76,25
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/609#discussion_r71950331
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -76,25
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/669
NIFI-2090 Add support for HL7 segment names and components in
ExtractHL7Attributes
Note that this doesn't apply the "friendly" names to for composite field
types and those are stil
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/565
Closing to resubmit against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jfrazee closed the pull request at:
https://github.com/apache/nifi/pull/565
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/609
@JPercivall Oh, right. I think these are corrected now but just noticed the
image bundle has a bunch of license violations (even after rebasing).
---
If your project is set up for it, you can reply
99 matches
Mail list logo