Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2985#discussion_r216626331
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.sh
---
@@ -16,16 +16,38
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2985
The errors seem unrelated. It complains about a timeout but one of the jobs
succeeded.
---
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/2985
NIFI-5573 Allow overriding of nifi-env.sh
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2823
Thanks for taking a look & committing!
---
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2881
+1 looks good to me (not a committer)
---
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2882
The pull request title and the commit is missing the JIRA number, could you
add that?
> Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve?
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/2878
NIFI-5408 Add documentation for NIFI-4279
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2872
Thanks! Unfortunately for some reason I can't see your new commit...
(I should maybe also add that I'm not a committer, I wast just interested
in this PR)
---
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2872#discussion_r201495972
--- Diff:
nifi-testharness/src/test/java/org/apache/nifi/testharness/samples/TestUtils.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2872#discussion_r201489283
--- Diff:
nifi-testharness/src/main/java/org/apache/nifi/testharness/TestNiFiInstance.java
---
@@ -0,0 +1,485 @@
+/*
+ * Licensed to the Apache
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2872#discussion_r201488527
--- Diff:
nifi-testharness/src/main/java/org/apache/nifi/testharness/TestNiFiInstance.java
---
@@ -0,0 +1,485 @@
+/*
+ * Licensed to the Apache
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2872#discussion_r201489086
--- Diff:
nifi-testharness/src/main/java/org/apache/nifi/testharness/TestNiFiInstance.java
---
@@ -0,0 +1,485 @@
+/*
+ * Licensed to the Apache
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2872#discussion_r201485489
--- Diff:
nifi-testharness/src/main/java/org/apache/nifi/testharness/TestNiFiInstance.java
---
@@ -0,0 +1,485 @@
+/*
+ * Licensed to the Apache
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2874
@mattyb149 I'd still argue that adding a hint to the JIRA would be a good
thing. Now there's no context at all. What is the bug you're referring to?
Sure, I can dig in the his
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2874
I did read the JIRA and referenced article. I also found
https://jira.apache.org/jira/browse/DDLUTILS-29 which fixes the same issue in
another project.
The only comment I have about the
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/2825
NIFI-5352 Change distribution to have the JARs and NARs in lib readable by
"other"
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the rev
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2823
The test failures are unrelated as far as I can tell
---
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/2823
NIFI-5350 Add a way to provide arbitrary Java options in shell scripts
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/1941
Regarding your question about the tests:
I did the same as in
[NIFI-1537](https://issues.apache.org/jira/browse/NIFI-1537): I tried this with
[snmpsim](https://github.com/etingof/snmpsim
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125168375
--- Diff:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java
---
@@ -389,30
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125168336
--- Diff:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPGetter.java
---
@@ -84,17 +83,21
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125168289
--- Diff:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java
---
@@ -47,7 +46,7
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125168182
--- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml ---
@@ -20,8 +20,8 @@ language governing permissions and limitations under the
Github user lfrancke commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125168139
--- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml ---
@@ -20,8 +20,8 @@ language governing permissions and limitations under the
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/1941
@trkurc Thank you for taking the time for your thorough review!
I'll go through everything you raised separately and will amend the pull
request.
You are totally correct t
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/1941
Both test failures are unrelated to the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/1941
NIFI-4099
- Code cleanup (consistent formatting, naming etc.)
- Update of SNMP4J from 1.10.1 to 2.5.6
- Fixes restartability issue because snmpTarget was not recreated
- Updates
27 matches
Mail list logo
