[GitHub] nifi pull request #2734: NIFI-5230: Fixed NPE in InvokeScriptedProcessor on ...

2018-05-23 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2734 NIFI-5230: Fixed NPE in InvokeScriptedProcessor on customValidate Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2616: NIFI-5052 Added DeleteByQuery ElasticSearch processor.

2018-05-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2616 +1 LGTM, ran the build with tests and contrib-check, also tested various situations (with/out incoming connections, valid/invalid queries, etc.) and all looks good. Thanks for this feature! Merging

[GitHub] nifi issue #2616: NIFI-5052 Added DeleteByQuery ElasticSearch processor.

2018-05-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2616 Sorry I lost track of this, was reviewing your other ones. I'll try to take a look ASAP ---

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189665908 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -120,6 +132,22 @@ 1.7.0-SNAPSHOT

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189696292 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r189676414 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-21 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2615 Reviewing... ---

[GitHub] nifi pull request #2728: NIFI-5143: Initial work to support column values fo...

2018-05-21 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2728 NIFI-5143: Initial work to support column values for paging results Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-05-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r189662885 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-05-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r189606932 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi issue #2720: NIFI-5217: Allow non-nullable fields to be added to MockRe...

2018-05-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2720 The Travis failure was on one build because of a port conflict, the others pass (with contrib-check). Merging to master, thanks! ---

[GitHub] nifi pull request #2720: NIFI-5217: Allow non-nullable fields to be added to...

2018-05-18 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2720 NIFI-5217: Allow non-nullable fields to be added to MockRecordParser Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-05-18 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r189287529 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-controller-service/src/main/java/org/apache/nifi/controller/livy/LivySessionController.java

[GitHub] nifi pull request #2715: Nifi-5171 - fixed Yandex Jersey issues by adding de...

2018-05-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2715#discussion_r189161793 --- Diff: nifi-nar-bundles/nifi-language-translation-bundle/nifi-yandex-processors/pom.xml --- @@ -53,7 +53,12 @@ jersey-media-json

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-05-17 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2718 NIFI-5213: Allow AvroReader to process files w embedded schema even when the access strategy is explicit schema Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi issue #2717: NIFI-5145: Fixed MockPropertyValue to call correct evaluat...

2018-05-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2717 Self-merging since Travis passed and the change is to the test framework. ---

[GitHub] nifi pull request #2717: NIFI-5145: Fixed MockPropertyValue to call correct ...

2018-05-17 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2717 NIFI-5145: Fixed MockPropertyValue to call correct evaluateAttributeExpressions when FF is null Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2714: NIFI-5145 Changed the override in MockPropertyValue to use...

2018-05-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2714 I think I spoke too soon, there are unit test failures. I'll look into it ---

[GitHub] nifi issue #2714: NIFI-5145 Changed the override in MockPropertyValue to use...

2018-05-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2714 +1 LGTM, thanks! (and sorry for my confusion) Merging to master ---

[GitHub] nifi issue #2712: NIFI-5197 Fixed a bunch of EL scope bugs.

2018-05-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2712 +1 LGTM, thanks for the updates! Merging to master ---

[GitHub] nifi issue #2712: NIFI-5197 Fixed a bunch of EL scope bugs.

2018-05-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2712 I'm on it... ---

[GitHub] nifi issue #1589: NIFI-1705 Adding AttributesToCSV processor

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1589 For furture reference, rather than merging master into your branch, I find it helpful to checkout master, pull the latest from upstream, then checkout your branch and rebase against master. There

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2672 +1 LGTM, made a couple of edits before merging (see comments), thanks for the improvement! Merging to master ---

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r188713507 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r188710133 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java --- @@ -202,6 +202,17 @@ public PropertyValue evaluateAttributeExpressions

[GitHub] nifi pull request #2709: NIFI-5202: Fixed timing issue in TestListDatabaseTa...

2018-05-16 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2709 NIFI-5202: Fixed timing issue in TestListDatabaseTables Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi pull request #2706: NIFI-5197 Fixed a bunch of EL scope bugs in the Mon...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2706#discussion_r188696201 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java

[GitHub] nifi issue #2707: NIFI-5200: Fixed bug that caused the wrong InputStream to ...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2707 ok have at it, didn't know you were reviewing :) Thanks! ---

[GitHub] nifi issue #2707: NIFI-5200: Fixed bug that caused the wrong InputStream to ...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2707 Reviewing... ---

[GitHub] nifi issue #2696: NIFI-5188: DruidTranquilityController does not fully suppo...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2696 @vakshorton do you mind taking a look at the changes? ---

[GitHub] nifi issue #2696: NIFI-5188: DruidTranquilityController does not fully suppo...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2696 The code changes LGTM, but I haven't built/tried them yet. I see quite a few [changes in 0.9.2](https://github.com/druid-io/druid/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aclosed%20mileston

[GitHub] nifi pull request #2672: NIFI-5145 Made MockPropertyValue.evaluateExpression...

2018-05-16 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2672#discussion_r188596962 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/GetHBase.java --- @@ -147,14 +146,6

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-15 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2672 I think the invalid scopes thing should be done in a separate Jira, there are more than just the ones above (~40 in total) so I think we should tackle them all at once, and have this PR just call

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-05-14 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r188147689 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-controller-service/src/main/java/org/apache/nifi/controller/livy/LivySessionController.java

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2614 Probably needed a git rebase --continue instead... ---

[GitHub] nifi issue #2614: Added Apache Pulsar Processors and Controller Service

2018-05-12 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2614 Something is a bit wonky with this latest push, perhaps a bad merge? ---

[GitHub] nifi pull request #2663: NIFI-5122 - Add Record Writer for S2S RTs

2018-05-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2663#discussion_r187685161 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/resources/docs

[GitHub] nifi issue #2630: NIFI-5041 Adds SPNEGO authentication to LivySessionControl...

2018-05-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2630 The changes LGTM, and I tested on a secure cluster, verifying that I could connect, get a session, and execute some simple Scala/Spark code. However, when I tested with various unhappy paths

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-05-03 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2588 Sounds good to me, especially if that project is active, I'd like to keep our dependencies as modules rather than code if possible. ---

[GitHub] nifi issue #2667: NIFI-5134 Explicitly requesting UGI to relogin before atte...

2018-05-03 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2667 +1 LGTM, looks like it will work like a barrier sync, the first one in will relogin if necessary, the rest will no-op, which means there won't be a race condition / threading issue when some o

[GitHub] nifi pull request #2663: NIFI-5122 - Add Record Writer for S2S RTs

2018-04-30 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2663#discussion_r185001042 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/resources/docs

[GitHub] nifi pull request #2663: NIFI-5122 - Add Record Writer for S2S RTs

2018-04-27 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2663#discussion_r184757759 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #2663: NIFI-5122 - Add Record Writer for S2S RTs

2018-04-27 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2663#discussion_r184757401 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi issue #2663: NIFI-5122 - Add Record Writer for S2S RTs

2018-04-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2663 Reviewing... ---

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-27 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184746728 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi issue #2642: NIFI-5090: Create move target dir dynamically at FetchFTP ...

2018-04-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2642 +1 LGTM, ran build with unit tests and contrib-check, also tested various configurations for moving files to new and existing directories. Thanks for the improvement! Merging to master ---

[GitHub] nifi issue #2642: NIFI-5090: Create move target dir dynamically at FetchFTP ...

2018-04-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2642 Reviewing... ---

[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...

2018-04-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2550 I think the new property is overkill and agree with @MikeThomsen that correcting the typo should not impact many users in any serious fashion. If we don't want to impact anyone and keep the cu

[GitHub] nifi pull request #2616: NIFI-5052 Added DeleteByQuery ElasticSearch process...

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2616#discussion_r184433040 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration

[GitHub] nifi pull request #2616: NIFI-5052 Added DeleteByQuery ElasticSearch process...

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2616#discussion_r184432400 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2616: NIFI-5052 Added DeleteByQuery ElasticSearch process...

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2616#discussion_r184432659 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -120,6 +115,18 @@ 1.7.0-SNAPSHOT

[GitHub] nifi issue #2616: NIFI-5052 Added DeleteByQuery ElasticSearch processor.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2616 Reviewing... ---

[GitHub] nifi issue #1937: NIFI-4105 support the specified Maximum value column and C...

2018-04-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1937 Sorry we lost track of this, I can review again but first can you rebase your commits against the latest master? Please and thanks! ---

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2018-04-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2003 @Wesley-Lawrence is this ready for "final" review? If so, do you mind rebasing this PR against the latest master? There are some conflicts listed above. Please and thanks! ---

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184407808 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2661: NIFI-5123: Move SchemaRegistryService to nifi-avro-...

2018-04-26 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2661 NIFI-5123: Move SchemaRegistryService to nifi-avro-record-utils Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184396268 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -57,6 +57,18 @@ provided

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184394354 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184392070 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184390680 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -120,6 +132,22 @@ 1.7.0-SNAPSHOT

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184395918 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-04-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r184393411 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi issue #2643: NIFI-5092 - Removed local state management for S2S Bulleti...

2018-04-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2643 +1 LGTM, ran build with unit tests and contrib-check, and verified the intended behavior. Thanks for this improvement! Merging to master ---

[GitHub] nifi pull request #2658: NIFI-5121: Added DBCPService API method for passing...

2018-04-25 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2658 NIFI-5121: Added DBCPService API method for passing in flow file attributes when available Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] nifi issue #2643: NIFI-5092 - Removed local state management for S2S Bulleti...

2018-04-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2643 Reviewing... ---

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-24 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r183797310 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosConfiguration.java --- @@ -0,0 +1,52

[GitHub] nifi issue #1589: NIFI-1705 Adding AttributesToCSV processor

2018-04-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1589 Another thing to consider here (although it would be a fair amount of refactor) is to repurpose this processor as AttributesToRecord. It doesn't add efficiency as a "record-aware&quo

[GitHub] nifi issue #2632: NIFI-5078 - added source/destination connection info in S2...

2018-04-20 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2632 +1 LGTM, ran build and unit tests (with contrib-check), also tested with a live NiFi instance and verified the new fields are there and populated correctly. Thanks for the improvement! Merging to

[GitHub] nifi issue #2645: NIFI-5095: Suppress SET property parse failure at Hive pro...

2018-04-20 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2645 +1 LGTM, ran build and unit tests. Thanks for this improvement! Merging to master ---

[GitHub] nifi pull request #2601: NIFI-3576 Support for QueryInfo relationship, usefu...

2018-04-19 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2601#discussion_r182733953 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2601: NIFI-3576 Support for QueryInfo relationship, usefu...

2018-04-18 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2601#discussion_r182589001 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2644: NIFI-4647: Fix support for strings in unions for Co...

2018-04-18 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2644 NIFI-4647: Fix support for strings in unions for ConvertAvroToORC Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response object...

2018-04-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2637 @JPercivall I forgot to sign off and put the "This closes" on the commit, do you mind closing this PR? Please and thanks and sorry about that! ---

[GitHub] nifi issue #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response object...

2018-04-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2637 +1 LGTM, ran build with unit tests. Thanks for the improvement! Merging to master ---

[GitHub] nifi pull request #2601: NIFI-3576 Support for QueryInfo relationship, usefu...

2018-04-18 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2601#discussion_r182498324 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2641: NIFI-5089: Exclude Maven progress output from Travi...

2018-04-17 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2641 NIFI-5089: Exclude Maven progress output from Travis builds Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi pull request #2640: NIFI-4456: Support multiple JSON objects in JSON re...

2018-04-17 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2640 NIFI-4456: Support multiple JSON objects in JSON record reader/writers Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #2638: NIFI-5082: Added support for custom Oracle timestam...

2018-04-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2638#discussion_r182100896 --- Diff: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java --- @@ -350,6 +350,8 @@ private static

[GitHub] nifi issue #2638: NIFI-5082: Added support for custom Oracle timestamp types...

2018-04-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2638 I REALLY didn't want to have to do this explicit Oracle stuff in the generic code, but the other options I tried weren't viable. I tried isolating the SQL type conversion to the Databa

[GitHub] nifi pull request #2638: NIFI-5082: Added support for custom Oracle timestam...

2018-04-17 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2638 NIFI-5082: Added support for custom Oracle timestamp types to Avro conversion Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-12 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r181075183 --- Diff: pom.xml --- @@ -94,6 +94,7 @@ 1.7.25 0.7.1 9.4.3.v20170317 +4.5.5 --- End diff

[GitHub] nifi pull request #2546: NIFI-4975 Add GridFS processors

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2546#discussion_r180937580 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2546: NIFI-4975 Add GridFS processors

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2546#discussion_r180938216 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/DeleteGridFS.java

[GitHub] nifi pull request #2546: NIFI-4975 Add GridFS processors

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2546#discussion_r180937998 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/AbstractGridFSProcessor.java

[GitHub] nifi pull request #2546: NIFI-4975 Add GridFS processors

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2546#discussion_r180937862 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/QueryHelper.java --- @@ -0,0 +1,67

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-04-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2575 +1 LGTM, ran full build with unit tests and tried Ambari Format as well as Record Format with an AvroRecordSetWriter. Verified the records are in the prescribed format and the standard S2S

[GitHub] nifi pull request #2601: NIFI-3576 Support for QueryInfo relationship, usefu...

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2601#discussion_r180773767 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2558#discussion_r180771987 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2558#discussion_r180772442 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/test/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2558#discussion_r180771727 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2558#discussion_r180771298 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingT...

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2575#discussion_r180769501 --- Diff: nifi-nar-bundles/nifi-ambari-bundle/nifi-ambari-reporting-task/pom.xml --- @@ -53,6 +43,11 @@ nifi-utils 1.6.0

[GitHub] nifi issue #2575: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-04-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2575 Mind doing another rebase? I will review shortly thereafter, thanks! ---

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180766269 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/PhoenixDatabaseAdapter.java

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180767606 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180767978 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180768758 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java

[GitHub] nifi pull request #2608: NIFI-5045: Fixed error code handling in PutHiveQL

2018-04-05 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2608 NIFI-5045: Fixed error code handling in PutHiveQL Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...

2018-04-04 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2605 @ijokarumawak Mind taking a look at this one? It changed the order of provenance events so it touched your code for emitting a FETCH-FORK (now it's a FORK-FETCH). Just want to make sur

[GitHub] nifi pull request #2605: NIFI-4862: Keep incoming flowfile attributes in out...

2018-04-04 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2605 NIFI-4862: Keep incoming flowfile attributes in outgoing flowfiles from SelectHiveQL Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

<    1   2   3   4   5   6   7   8   9   10   >