GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2247
NIFI-4473: Fixed SelectHiveQL flowfile handling during error conditions
So the behavior is inconsistent with other processors like ExecuteSQL, but
it has always been that way, so this fix is just
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2239#discussion_r148626386
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestHiveParser.java
---
@@ -0,0 +1,240
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2239#discussion_r148636452
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -216,4
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2239
Reviewing...
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2246#discussion_r148575679
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2246
NIFI-4559: Add non-zero status relationship to ExecuteStreamCommand
Sorry about the whitespace changes, I must have slightly different (but
still compliant) formatting settings in my IDE
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1662#discussion_r148413690
--- Diff:
nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1662#discussion_r148412300
--- Diff:
nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/resources/docs/org.apache.nifi.processors.groovyx.ExecuteGroovyScript
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1662#discussion_r148412458
--- Diff: nifi-nar-bundles/pom.xml ---
@@ -94,7 +95,7 @@
-
+
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1662#discussion_r148412024
--- Diff:
nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/resources/docs/org.apache.nifi.processors.groovyx.ExecuteGroovyScript
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1662#discussion_r148411913
--- Diff:
nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/resources/docs/org.apache.nifi.processors.groovyx.ExecuteGroovyScript
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2245
NIFI-4496: Added JacksonCSVRecordReader to allow choice of CSV parser
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2242#discussion_r148080171
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryRecord.java
---
@@ -102,6
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2175
Hmm, that's interesting, deleting with ID not found was my whole point of
using "result" instead of "reason". What version of ES are you using to test
against? I wonder if
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
I talked to @markap14 about it, perhaps this fix is fine or we can just
change it to a boolean, but I'll let him take a look too.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2223
+1 LGTM, ran full build w contrib-check and unit tests. Thanks for the
improvement! Merging to master
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2223#discussion_r147526938
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -625,7
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2226#discussion_r147526473
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
---
@@ -227,9
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2226
NIFI-4080: Added EL support to fields in ValidateCSV
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2175
If you need to raise the logging level, you can add that processor to
logback.xml with a setting of INFO, otherwise you can change all processors to
INFO with the following sed statement (works on
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2175
Before the fix, you would probably see a log statement for each failed doc.
Also for some "not found" errors, such as maybe deleting a doc that doesn't
exist? you would see an empty
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2221#discussion_r146999573
--- Diff:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/paths/RecordPathCompiler.java
---
@@ -346,4 +356,19 @@ private static
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2175
This PR was about error handling, could you try 10k bad
documents/operations?
---
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2225
NIFI-4522: Add SQL Statement property to PutSQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2162
Yes, sorry for the delay, got swamped
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2215
Good catch on this error, thanks! the fix and test LGTM, merging to master
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
I'm getting NPEs in the unit tests, something weird with MockPropertyValue
getting created without "expectExpressions" being set to anything, causing
isExpressionLanguagePresent() to throw the NPE
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2207#discussion_r145185287
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2207#discussion_r145185126
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2207#discussion_r145169320
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2207#discussion_r145169617
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2207#discussion_r145169184
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2207
Reviewing...
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2212#discussion_r145140092
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
---
@@ -243,95 +284,152
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2212
NIFI-4473: Add support for large result sets and normalizing Avro names to
SelectHiveQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1662#discussion_r144080861
--- Diff: nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-nar/pom.xml ---
@@ -0,0 +1,44 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1955#discussion_r144079474
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2132#discussion_r144077813
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2132#discussion_r144078102
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2184
This branch looks out of whack with the current master, can you start with
a fresh master and cherry-pick in your commits for this issue? It will help
with merging and review, thanks!
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2094
Do you mind rebasing against the latest master due to merge conflicts?
Please and thanks!
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2113
If you're looking to run integration tests against a ES instance (from the
Maven plugin), perhaps you can split out the integration tests into a new file
called ITJsonQueryElasticsearch5, r
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143454165
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143454076
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143453629
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143334704
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2104
Your instinct about Compilable is spot-on, it's exactly when I stopped
working this branch :P For ExecuteScript, I'd thought such a processor would be
for quick onTrigger() implementation
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r143296927
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -66,6
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143294482
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143295816
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143294684
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143295442
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
The "unit tests" for TestSelectHiveQL use Derby as the database, only to
test the functionality of getting the "HiveQL" statement to the database and
parsing its results.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143279372
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143289820
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143290546
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143279020
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143290669
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143280289
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143278853
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2162#discussion_r143289913
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2104
@MikeThomsen We've talked a bit on the mailing lists, what do you want to
do here? I want to make sure your contribution is recognized, as those changes
were an integral part of my own b
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r143281834
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -66,6
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1937
This PR seems to have some conflicts, can you rebase your commits against
the latest master? Please and thanks!
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2188
+1 LGTM, ran unit tests and contrib-check, verified NiFi flows against
Cassandra 2.1.19 and 3.11.0, also verified the [protocol support
matrix](http://docs.datastax.com/en/developer/java-driver/3.3
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r143055024
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
---
@@ -290,6 +292,9
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2192
+1 LGTM, ran build with unit tests and contrib-check. Thanks for the
improvement! Merging to master
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1471
+1 LGTM, Ran unit tests and contrib-check, also tested with a MySQL stored
procedure returning 2 ResultSets, verified two flow files were output, each
with the correct row count attribute. Thanks
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1471#discussion_r142700529
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -196,44
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2172
+1 LGTM, ran the unit tests and with a live NiFi, verified I could use
Unicode and other escaped character(s) as a delimiter. Thanks again! This time
I'm really merging to master :)
---
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2175
NIFI-4410: Improved error handling/logging in PutElasticsearchHttp
processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2172
Yes please, let's use yours :)
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140892049
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140891808
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2172
I took the liberty of fixing the unescapeString issue above and verified
that the PR's intended functionality is working (tried a Unicode escape
character as a delimiter). I will add my comm
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140882102
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140831954
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140836194
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/resources/csv/multi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140831829
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2172#discussion_r140831975
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2174
NIFI-4345: Removed lookup-services dependency from MongoDB Services NAR,
cleaned up dependencies
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2166
The unit test doesn't pass when this PR is rebased against master, due to
[NIFI-3484](https://issues.apache.org/jira/browse/NIFI-3484). I can fix this
when I merge.
+1 LGTM, ver
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2123
I took the liberty of changing the Lookup Key property to Lookup Value
Field, and updated variables and unit tests and such. +1 LGTM, built and ran
unit tests, also tried a flow with LookupRecord
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2169
+1 LGTM, built and ran unit tests, and tried two queries with different
result sets, verified the different schemas and values were output correctly.
Thanks for the improvement! Merging to master
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2169
Reviewing...
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r140537987
--- Diff: pom.xml ---
@@ -1109,7 +1109,7 @@
org.apache.nifi
-nifi-kudu-nar
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r140531630
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2050
+1 LGTM, ran build and unit tests (and contrib-check), also tested both
GenerateTableFetch and QueryDatabaseTable with MySQL and Oracle DBs and various
WHERE clauses. Great work! Merging to master
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2050
Do you mind rebasing this against the latest master? the code LGTM so will
run it once it builds cleanly, and merge if all is well, thanks in advance!
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2091
+1 LGTM, built and ran unit tests, also verified the correct behavior on
MySQL, Oracle 11, and Postgres DBs. Thanks for the improvement! Merging to
master
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137378308
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services/.gitignore
---
@@ -0,0 +1 @@
+/bin/
--- End
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137376343
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137374051
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services-nar/src/main/resources/META-INF/NOTICE
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137374387
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137376949
--- Diff: pom.xml ---
@@ -1109,7 +1109,7 @@
org.apache.nifi
-nifi-kudu-nar
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2063
+1 LGTM, built and ran unit tests, and tried with a live MongoDB instance,
verified both JSON modes produce the expected output. Thanks for the
improvement! Merging to master
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2120
+1 LGTM, built and ran tests, looks good, thanks for the improvement!
Merging to master
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2129
+1 LGTM, built and ran unit tests and tried with a MySQL database, verified
the attribute is being written correctly. Thanks for the improvement! Merging
to master
---
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2130
NIFI-3970: Add CSVRecordLookupService
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2129
Reviewing...
---
701 - 800 of 1416 matches
Mail list logo
