[GitHub] nifi issue #2501: NIFI-4743 Added configurable null suppression to PutElasti...

2018-03-14 Thread robertrbruno
Github user robertrbruno commented on the issue: https://github.com/apache/nifi/pull/2501 @MikeThomsen changes look good to me. ---

[GitHub] nifi pull request #2501: NIFI-4743 Added configurable null suppression to Pu...

2018-03-13 Thread robertrbruno
Github user robertrbruno commented on a diff in the pull request: https://github.com/apache/nifi/pull/2501#discussion_r174307349 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2501: NIFI-4743 Added configurable null suppression to Pu...

2018-03-13 Thread robertrbruno
Github user robertrbruno commented on a diff in the pull request: https://github.com/apache/nifi/pull/2501#discussion_r174305856 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #2501: NIFI-4743 Added configurable null suppression to PutElasti...

2018-03-01 Thread robertrbruno
Github user robertrbruno commented on the issue: https://github.com/apache/nifi/pull/2501 Gave your addition a quick look. You should be fine, but I believe unnecessary since the writevalue function will never be called when the value is "null" due to the continue