[GitHub] nifi issue #2910: NIFI-5446: Specify the file encoding option to UTF-8 in po...

2018-10-18 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2910 Thanks for reviewing and merging it, @ijokarumawak! ---

[GitHub] nifi issue #2910: NIFI-5446: Specify the file encoding option to UTF-8 in po...

2018-10-17 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2910 Could somebody please review it? ---

[GitHub] nifi pull request #2910: NIFI-5446: Specify the file encoding option to UTF-...

2018-07-23 Thread tasanuma
GitHub user tasanuma opened a pull request: https://github.com/apache/nifi/pull/2910 NIFI-5446: Specify the file encoding option to UTF-8 in pom.xml Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2582: NIFI-4923 Updated nifi-hadoop-libraries-nar, nifi-hdfs-pro...

2018-04-11 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2582 Thanks for working on this task. Basically, Wire Protocols between Hadoop clients and servers can be broken if they aren't within a major version. I think we should carefully proceed

[GitHub] nifi issue #2503: NIFI-4855: The layout of NiFi API document is broken

2018-03-06 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2503 Thanks for reviewing and committing it, @mcgilman! ---

[GitHub] nifi pull request #2503: NIFI-4855: The layout of NiFi API document is broke...

2018-03-04 Thread tasanuma
Github user tasanuma commented on a diff in the pull request: https://github.com/apache/nifi/pull/2503#discussion_r172100595 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/resources/templates/index.html.hbs --- @@ -675,6 +676,14

[GitHub] nifi issue #2503: NIFI-4855: The layout of NiFi API document is broken

2018-03-01 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2503 This pull-request uses _**notes**_ variables instead of _**value**_ variables for long sentences. Before: https://issues.apache.org/jira/secure/attachment/12909857/broken_ui.png After

[GitHub] nifi pull request #2503: NIFI-4855: The layout of NiFi API document is broke...

2018-03-01 Thread tasanuma
GitHub user tasanuma opened a pull request: https://github.com/apache/nifi/pull/2503 NIFI-4855: The layout of NiFi API document is broken Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-27 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2493 Hi @david-streamlio. Thanks for the work. This would really helpful for Pulsar users. I have one question. Are there any reasons that this processor uses Controller Service? I think

[GitHub] nifi issue #2143: NiFi-4338: Add documents for how to use SSL protocol from ...

2017-10-09 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 Thanks for reviewing and committing it, @joewitt and @ijokarumawak! ---

[GitHub] nifi issue #2143: NiFi-4338: Add documents for how to use SSL protocol from ...

2017-10-09 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 Thanks for the review and the comments, @joewitt and @ijokarumawak. I understand. I simply added the description to the option in the parent processor of HDFS. I created a common

[GitHub] nifi issue #2143: NiFi-4338: Add documents for how to use SSL protocol from ...

2017-09-14 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 @ijokarumawak Thanks for the review and the comments! Yes, all the additionalDetails.html is the same. I agree with you that putting it in the document of PutHDFS. I updated my pull request based

[GitHub] nifi issue #2143: Nifi-4338: Support SSL Context Service in HDFS processors

2017-09-13 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 I reverted the last commit and added some documents for how to use SSL protocol as 'additionalDetails.html' in HDFS processors. Please review it when you are free. ---

[GitHub] nifi issue #2143: Nifi-4338: Support SSL Context Service in HDFS processors

2017-09-12 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 I found that Hadoop has some properties for SSL protocols. https://hadoop.apache.org/docs/r2.8.0/hadoop-mapreduce-client/hadoop-mapreduce-client-core/EncryptedShuffle.html After setting

[GitHub] nifi issue #2143: Nifi-4338: Support SSL Context Service in HDFS processors

2017-09-11 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 Hello Bryan, thanks for the review! I see. Other processors which use SSL Context Service use SSLContext class to pass the SSL/TLS values. I will investigate whether hadoop client can use it or not. ---

[GitHub] nifi issue #2143: Nifi-4338: Support SSL Context Service in HDFS processors

2017-09-11 Thread tasanuma
Github user tasanuma commented on the issue: https://github.com/apache/nifi/pull/2143 I did some system tests for this change and checked it works fine. But it is hard to write a unit test for using SWebHdfs from NiFi and I was not able to do. This is my first contribution

[GitHub] nifi pull request #2143: Nifi 4338

2017-09-11 Thread tasanuma
GitHub user tasanuma opened a pull request: https://github.com/apache/nifi/pull/2143 Nifi 4338 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken