[GitHub] nifi issue #399: NIFI-1833 - Adding Azure Storage processors

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/399 @slachterman - thank you for the handy link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1332: NIFI-3163: Flow Fingerprint should include new RPG configu...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1332 @ijokarumawak - This PR needs rebasing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1378: NIFI-2952 Fixed search value validation in ReplaceText

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1378 @pvillard31 interestingly enough I just gone through a PR by @apsaltis that has more or less the same ethos as yours (PR#1331). His is focused on MiNiFi, while yours is perhaps a bit more NiFi

[GitHub] nifi issue #349: NIFI-1767 AWS IoT processors

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/349 @joewitt - I am happy to adopt the stalled PR and address @JPercivall 's comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1521 NIFI-1767 - Added 1st iteration of IOT-Processors for reading and wri… …ting AWS IOT shadow and MQTT topics This closes: #349 Thank you for submitting a contribution to Apache

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 @KayLerch - Thank you for the contribution, I squashed your commit but left attribution untouched so credit is due to who deserves it. @JPercivall this is not ready to review. For now the PR

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101915841 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101915884 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 JPercivall Does AWS IoT support communicating over SSL with MQTT or shadows? If so, that option should be added. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** The more I type out and try to easily distinguish GetAWSIoT/PutAWSIoT and GetAWSIoTShadow/PutAWSIoTShadow the more I think MQTT should be integrated into the name and all four of

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** I actually already committed general MQTT processors [1] and they have some good "best practices" with regards to publishing/consuming messages and MQTT I think wou

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** A bit nit picky and I may be alone here, but I find putting "if" statements and their content on the same line a bit hard to read when trying to read someone else&#

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916002 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/MqttWebSocketAsyncClient.java

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** For the new dependencies, NOTICE/LICENSE information needs to be added if applicable. Paho is EPL 1.0 licensed and requires being added to the nar NOTICE like so[1]. Do the other

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916052 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916039 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** The Get/PutAWSIoT processors read and overwrite mqttClient many times without a read/write lock, this can lead to problems in multi-threaded scenarios. For example, the both

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916076 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916101 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/IoTMessage.java --- @@ -0,0 +1,44

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916129 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoTShadow.java --- @@ -0,0 +1,107

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916202 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java --- @@ -0,0 +1,114

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916245 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java --- @@ -0,0 +1,114

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** A couple places have weird comments like "// @TRACE 252=connect to host {0} port {1} timeout {2}". Is this a convention I'm not aware of or left over from copy/

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** Currently the only tests are integration tests that rely on an AWS instance. I would like to see more true unit tests. For inspiration, check out the Publish/Consume MQTT unit

[GitHub] nifi issue #1331: NIFI-3196 Provide MiNiFi FlowStatus Insights processor tha...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1331 @apsaltis - glad comments were helpful. New PR or not, the work is truly great and I can confess that with the exception of Azure components I will very likely be using it the outcome of the

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 @JPercivall The code, being based on 0.7 wouldn't compile cleanly when merged with 1.x so I am working in getting it to compile. I also I think I transferred most of the comments acros

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 @JPercivall @joewitt The original PR seems to contain significant sections of code that are close to an old version of the following code: https://github.com/inventit/mqtt

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 https://github.com/aws/aws-iot-device-sdk-java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 To further my above comments, it seems that shortly after the original PR, AWS released an IoT SDK for Java under ASL2 license. I vote we close this PR and restart work using AWS' ow

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 Close due to reasons presented above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1521: NIFI-1767 - Add IOT-Processors for reading and writ...

2017-02-20 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #349: NIFI-1767 AWS IoT processors

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/349 Thabk Kay, would it be possible to close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1395 @nickcarenza - welcome. We all have been in that very same boat once. :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #1378: NIFI-2952 Fixed search value validation in ReplaceText

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1378 @pvillard31 :rofl: yeah... wrong PR but glad you got it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1240: NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Ro...

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1240 @bbende @markap14 or @joewitt I suspect this PR and its 0.x counterpart will benefit from having one of you reviewing it? --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1519: [NIFI3501] Upgrade D3 to 3.5.17 and allow npm to pull it d...

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1519 @mcgilman any chance of having a look on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/379 @pvillard31 not sure if it is the case but have you by any chance tried to use the Hadoop alluxio interfaces with puthdfs and co instead of a new processor? e.g https

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/379 And by last comment I naturally refer to use a customised core-site.xml that includes: ``` fs.alluxio.impl alluxio.hadoop.FileSystem The Alluxio FileSystem (Hadoop 1.x

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/379 @pvillard31 that connection strategy is agnostic to the underlying filesystem supporting alluxio. What it does is to allow a hadoop compatible application to access alluxio without further coding and

[GitHub] nifi pull request #1526: NIFI-3514 - Ensures ListGCPBucket triggers serially...

2017-02-22 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1526 NIFI-3514 - Ensures ListGCPBucket triggers serially and forbids inputs Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #1526: NIFI-3514 - Ensures ListGCPBucket triggers serially and fo...

2017-02-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1526 @jvwing @gene-telligent - would you mind having a look ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1529 @WilliamNouet to squash commit just checkout your branch and run: `git rebase -i` and follow the squash process as very well exemplified here: http://gitready.com/advanced

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102853739 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102854106 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/pom.xml --- @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102854253 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102854353 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/pom.xml --- @@ -40,7 +40,21 @@ org.apache.nifi nifi-utils

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102855578 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi issue #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1529 @WilliamNouet - thank you for the contribution. Had a quick look and added some comments. Other will probably want to have a look as well. --- If your project is set up for it, you can reply to this

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102856855 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java --- @@ -0,0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102860592 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java --- @@ -0,0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102860737 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java --- @@ -0,0

[GitHub] nifi issue #1528: NIFI-385 Add Kerberos support in nifi-kite-nar

2017-02-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1528 @WilliamNouet this looks like a duplicated PR from the other one introducing Morphlines? If so, mind to close it? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1528: NIFI-385 Add Kerberos support in nifi-kite-nar

2017-02-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1528 Thanks for the heads up @pvillard31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1541: NIFI-329 - Introduce IRC Client Services and Consum...

2017-02-24 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1541 NIFI-329 - Introduce IRC Client Services and ConsumeIRC processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-02-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 this PR still not ready to review, however given this is the first time I am putting together a ControllerService I would appreciate some early feedback. As you can see, design for the

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-02-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 also note that the easier way of setting up an IRC for testing is to spin up miniircd, which works like a charm for basic testing --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599319 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599241 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599499 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,233

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599675 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103645596 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,233

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103647459 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/pom.xml --- @@ -0,0 +1,76 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103648185 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103648209 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/event/LumberjackEvent.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103649158 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103650361 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103651066 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103652588 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103653787 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi issue #1418: NIFI-3238 - Introduce ListenBeats processor and deprecates...

2017-03-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1418 @mattyb149 - hopefully addressed your feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 Looks good. Will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1016#discussion_r103875643 --- Diff: nifi-nar-bundles/nifi-jmx-bundle/nifi-jmx-processors/src/main/java/org/apache/nifi/processors/jmx/GetJMX.java --- @@ -0,0 +1,415

[GitHub] nifi pull request #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1016#discussion_r103875149 --- Diff: nifi-nar-bundles/nifi-jmx-bundle/nifi-jmx-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] nifi pull request #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1016#discussion_r103875353 --- Diff: nifi-nar-bundles/nifi-jmx-bundle/nifi-jmx-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 processor logic is theoretically complete. Now finishing the IRC over TLS logic --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request #1551: NIFI-3054 - Create default all default directions a...

2017-03-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1551 NIFI-3054 - Create default all default directions as part of maven-as… …sembly Update Admin Guide with recommended directory permissions Update some minor

[GitHub] nifi issue #1551: NIFI-3054 - Create default all default directions as part ...

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1551 @alopresto may I ask your opinion on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1552: NIFI-3544 - Fixes minor typo n ExtractEmailHeaders ...

2017-03-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1552 NIFI-3544 - Fixes minor typo n ExtractEmailHeaders log message Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1553 NIFI-1449 - Migrate PutEmail tests from Mock class to ListenSMTP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #1553: NIFI-1449 - Migrate PutEmail tests from Mock class to List...

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1553 @joewitt - Perhaps you would you be able to give me some insight here. For some reason when I run the following lines of testOutgoingMessageAttachment

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104021856 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104027407 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104027988 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -102,13

[GitHub] nifi issue #1543: NIFI-1750 - updated dict file desc

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1543 @joetrite is there a chance you can squash this commit into a single commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104113002 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104114824 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104143931 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104170950 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi issue #1553: NIFI-1449 - Migrate PutEmail tests from Mock class to List...

2017-03-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1553 Thanks for the assistance previously, it should be ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #1563: NIFI-XXXX - Renames jBcrypt dependency to jBCrypt

2017-03-04 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1563 NIFI- - Renames jBcrypt dependency to jBCrypt Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #1563: NIFI-3554 - Renames jBcrypt dependency to jBCrypt

2017-03-04 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1563 merged pere's patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] nifi pull request #1563: NIFI-3554 - Renames jBcrypt dependency to jBCrypt

2017-03-04 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #1551: NIFI-3054 - Create all default directories as part of mave...

2017-03-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1551 @joewitt thanks for your comments. I understand your concerns but isn't the user change of the default settings (we do ship with default location settings after all) a voluntary a

[GitHub] nifi issue #1551: NIFI-3054 - Create all default directories as part of mave...

2017-03-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1551 @joewitt. Thanks for the comment. I will go through your notes and adjust the PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1581: NIFI-3534 Add support for impersonating a user with HDFS p...

2017-03-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1581 @apsaltis LGTM but is there chance of making reference to proxyuser groups/ proxyuser hosts in the description or additional info? HDFS Impersonation is one of those thing people always get wrong the

[GitHub] nifi pull request #1614: NIFI-3466 - Addresses ParseCEF Locale related failu...

2017-03-22 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1614 NIFI-3466 - Addresses ParseCEF Locale related failures and introduce ability to define Locale of logs Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...

2017-03-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1614 @pvillard31 @apiri this should hopefully address the Locale related errors affecting ParseCEF. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...

2017-03-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1614 also please note there seem to be an unrelated issue affecting another test unit that fails unter pt_BR and fr_FR but passes ja_JP. I suspect it is a comma vs dot number notation issue

[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...

2017-03-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1614 please ignore the last comment regarding the error above, seems to be a rebasing issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-03-24 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1619 NIFI-2747 - Introduce FuzzyHashContent processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

<    1   2   3   4   5   6   7   8   >