Re: [PR] NIFI-15030 Filter blank Header Names from Responses in InvokeHTTP [nifi]

2025-10-01 Thread via GitHub
mosermw commented on PR #10360: URL: https://github.com/apache/nifi/pull/10360#issuecomment-3358336654 > Why this PR closed without merging? This PR did get merged. I pushed to https://git-wip-us.apache.org/repos/asf/nifi.git instead of https://github.com/apache/nifi.git and apparen

Re: [PR] NIFI-15030 Filter blank Header Names from Responses in InvokeHTTP [nifi]

2025-10-01 Thread via GitHub
agrawald commented on PR #10360: URL: https://github.com/apache/nifi/pull/10360#issuecomment-3358225669 Why this PR closed without merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] NIFI-15033 selected styles applied to appearance and animations globa… [nifi]

2025-10-01 Thread via GitHub
scottyaslan opened a new pull request, #10364: URL: https://github.com/apache/nifi/pull/10364 …l menus # Summary [NIFI-15033](https://issues.apache.org/jira/browse/NIFI-15033) Apply selected class styles to global menu items

Re: [PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-10-01 Thread via GitHub
dan-s1 commented on code in PR #10351: URL: https://github.com/apache/nifi/pull/10351#discussion_r2394825304 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTest.java: ##

[PR] NIFI-15032 Add Key Pair Authentication to Snowflake Connection Pool [nifi]

2025-10-01 Thread via GitHub
exceptionfactory opened a new pull request, #10363: URL: https://github.com/apache/nifi/pull/10363 # Summary [NIFI-15032](https://issues.apache.org/jira/browse/NIFI-15032) Adds support for [Key Pair Authentication](https://docs.snowflake.com/en/user-guide/key-pair-auth) to the `Snow

Re: [PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-10-01 Thread via GitHub
dan-s1 commented on code in PR #10351: URL: https://github.com/apache/nifi/pull/10351#discussion_r2394825304 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTest.java: ##

[PR] NIFI-15018 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundles nifi-email-bundle, nifi-enrich-bundle, nifi-evtx

2025-10-01 Thread via GitHub
dan-s1 opened a new pull request, #10362: URL: https://github.com/apache/nifi/pull/10362 # Summary [NIFI-15018](https://issues.apache.org/jira/browse/NIFI-15018) # Tracking Please complete the following tracking steps pr

Re: [PR] NIFI-15005 route not found [nifi]

2025-10-01 Thread via GitHub
rfellows commented on code in PR #10350: URL: https://github.com/apache/nifi/pull/10350#discussion_r2394875239 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/app.component.html: ## @@ -15,9 +15,4 @@ ~ limitations under the License. --> - - - -

Re: [PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-10-01 Thread via GitHub
exceptionfactory commented on code in PR #10351: URL: https://github.com/apache/nifi/pull/10351#discussion_r2395288598 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTes

Re: [PR] NIFI-15004 nifi registry about dialog [nifi]

2025-10-01 Thread via GitHub
rfellows merged PR #10347: URL: https://github.com/apache/nifi/pull/10347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache

Re: [PR] NIFI-14727 Create new ConsumeKinesis Processor [nifi]

2025-10-01 Thread via GitHub
awelless commented on code in PR #10077: URL: https://github.com/apache/nifi/pull/10077#discussion_r2394208883 ## nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesis.java: ## @@ -0,0 +1,740 @@ +/* + * Licens

[PR] NIFI-15030 Filter blank Header Names from Responses in InvokeHTTP [nifi]

2025-10-01 Thread via GitHub
exceptionfactory opened a new pull request, #10360: URL: https://github.com/apache/nifi/pull/10360 # Summary [NIFI-15030](https://issues.apache.org/jira/browse/NIFI-15030) Filters out blank HTTP response header names when handling responses in the `InvokeHTTP` Processor. The filterin

Re: [PR] MINIFICPP-2643 Fix clang tidy issues [nifi-minifi-cpp]

2025-10-01 Thread via GitHub
fgerlits commented on code in PR #2040: URL: https://github.com/apache/nifi-minifi-cpp/pull/2040#discussion_r2394340315 ## libminifi/test/libtest/integration/ConnectionCountingServer.cpp: ## @@ -85,14 +85,13 @@ void ReverseBodyPostHandler::saveConnectionId(struct mg_connection*

Re: [PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-10-01 Thread via GitHub
dan-s1 commented on code in PR #10351: URL: https://github.com/apache/nifi/pull/10351#discussion_r2394825304 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTest.java: ##

Re: [PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-10-01 Thread via GitHub
dan-s1 commented on code in PR #10351: URL: https://github.com/apache/nifi/pull/10351#discussion_r2394825304 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTest.java: ##

Re: [PR] NIFI-15030 Filter blank Header Names from Responses in InvokeHTTP [nifi]

2025-10-01 Thread via GitHub
mosermw commented on PR #10360: URL: https://github.com/apache/nifi/pull/10360#issuecomment-3356796118 +1 this looks good. I appreciate the additional unit test and the minor cleanup in InvokeHTTPTest. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-10-01 Thread via GitHub
dan-s1 commented on code in PR #10351: URL: https://github.com/apache/nifi/pull/10351#discussion_r2394825304 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTest.java: ##

Re: [PR] NIFI-15005 route not found [nifi]

2025-10-01 Thread via GitHub
rfellows commented on code in PR #10350: URL: https://github.com/apache/nifi/pull/10350#discussion_r2394680803 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/resources/feature/resources.component.html: ## @@ -15,8 +15,11 @@ ~ limitations under the License.

[PR] NIFI-15031 Remove historical fallback Remote PG registration requests [nifi]

2025-10-01 Thread via GitHub
exceptionfactory opened a new pull request, #10361: URL: https://github.com/apache/nifi/pull/10361 # Summary [NIFI-15031](https://issues.apache.org/jira/browse/NIFI-15031) Removes historical fallback handling of unauthorized status responses in Remote Process Group communication.

Re: [PR] NIFI-14727 Create new ConsumeKinesis Processor [nifi]

2025-10-01 Thread via GitHub
awelless commented on code in PR #10077: URL: https://github.com/apache/nifi/pull/10077#discussion_r2394335847 ## nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesis.java: ## @@ -0,0 +1,740 @@ +/* + * Licens

[PR] MINIFICPP-2643 Fix clang tidy issues [nifi-minifi-cpp]

2025-10-01 Thread via GitHub
lordgamez opened a new pull request, #2040: URL: https://github.com/apache/nifi-minifi-cpp/pull/2040 https://issues.apache.org/jira/browse/MINIFICPP-2643 -- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of t

Re: [PR] NIFI-14727 Create new ConsumeKinesis Processor [nifi]

2025-10-01 Thread via GitHub
awelless commented on code in PR #10077: URL: https://github.com/apache/nifi/pull/10077#discussion_r2394216916 ## nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesis.java: ## @@ -0,0 +1,740 @@ +/* + * Licens

Re: [PR] NIFI-15029 - Update tabbed dialog to leverage InjectionToken, allowing subclasses to define their own dialogId [nifi]

2025-09-30 Thread via GitHub
mcgilman merged PR #10358: URL: https://github.com/apache/nifi/pull/10358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache

Re: [PR] MINIFICPP-2605 Generate MQTT client id in MQTT processors if not set in property [nifi-minifi-cpp]

2025-09-30 Thread via GitHub
szaszm closed pull request #2006: MINIFICPP-2605 Generate MQTT client id in MQTT processors if not set in property URL: https://github.com/apache/nifi-minifi-cpp/pull/2006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] MINIFICPP-2642 std::invocable should be used with std::invoke [nifi-minifi-cpp]

2025-09-30 Thread via GitHub
szaszm closed pull request #2038: MINIFICPP-2642 std::invocable should be used with std::invoke URL: https://github.com/apache/nifi-minifi-cpp/pull/2038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] NIFI-15016 - Ensure nested versioned groups detect scheduled-state changes [nifi]

2025-09-30 Thread via GitHub
exceptionfactory commented on code in PR #10356: URL: https://github.com/apache/nifi/pull/10356#discussion_r2392935682 ## nifi-registry/nifi-registry-core/nifi-registry-flow-diff/src/test/java/org/apache/nifi/registry/flow/diff/TestStandardFlowComparator.java: ## @@ -285,6 +286,

Re: [PR] NIFI-15028 - Ensure parameter context edit async polling stops after cancelling the update [nifi]

2025-09-30 Thread via GitHub
mcgilman commented on PR #10357: URL: https://github.com/apache/nifi/pull/10357#issuecomment-3353471267 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] NIFI-15028 - Ensure parameter context edit async polling stops after cancelling the update [nifi]

2025-09-30 Thread via GitHub
rfellows opened a new pull request, #10357: URL: https://github.com/apache/nifi/pull/10357 # Summary [NIFI-15028](https://issues.apache.org/jira/browse/NIFI-15028) **Fix parameter context update polling cancellation and improve test quality** ### 🎯 **Problem Solved:**

Re: [PR] MINIFICPP-2565 Add compression support for site to site communication [nifi-minifi-cpp]

2025-09-30 Thread via GitHub
szaszm commented on code in PR #1974: URL: https://github.com/apache/nifi-minifi-cpp/pull/1974#discussion_r2382900318 ## libminifi/include/sitetosite/CompressionOutputStream.h: ## @@ -0,0 +1,49 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-29 Thread via GitHub
scottyaslan commented on code in PR #10346: URL: https://github.com/apache/nifi/pull/10346#discussion_r2389013437 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/state/buckets/buckets.effects.ts: ## @@ -16,44 +16,191 @@ */ import { inject, Injectable } from '@

Re: [PR] NIFI-15005 route not found [nifi]

2025-09-29 Thread via GitHub
rfellows commented on code in PR #10350: URL: https://github.com/apache/nifi/pull/10350#discussion_r2388912490 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/ui/common/page-content/page-content.component.html: ## @@ -0,0 +1,21 @@ + + + +{{ title }} + + Re

Re: [PR] NIFI-15004 nifi registry about dialog [nifi]

2025-09-29 Thread via GitHub
rfellows commented on code in PR #10347: URL: https://github.com/apache/nifi/pull/10347#discussion_r2388870758 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/ui/common/about-dialog/about-dialog.component.html: ## @@ -0,0 +1,47 @@ + + + +About NiFi Registry +

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-29 Thread via GitHub
rfellows commented on code in PR #10346: URL: https://github.com/apache/nifi/pull/10346#discussion_r2388694622 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/state/buckets/buckets.effects.ts: ## @@ -16,44 +16,191 @@ */ import { inject, Injectable } from '@ang

Re: [PR] MINIFICPP-2603 Add Record Reader and Record Writer properties to MQTT processors [nifi-minifi-cpp]

2025-09-29 Thread via GitHub
fgerlits commented on code in PR #2004: URL: https://github.com/apache/nifi-minifi-cpp/pull/2004#discussion_r2388437014 ## minifi-api/include/minifi-cpp/core/Record.h: ## @@ -47,6 +47,10 @@ class Record final { return fields_.at(key); } + [[nodiscard]] bool contains(c

Re: [PR] NIFI-15014 allow advanced UpdateAttribute Rules to be searched even i… [nifi]

2025-09-29 Thread via GitHub
rfellows commented on PR #10345: URL: https://github.com/apache/nifi/pull/10345#issuecomment-3347096896 @markobean I'm confused by this statement >...the only update is in the backend code serving the search results This change is most definitely a UI change and NOT a backend change

[PR] NIFI-15025 : LookupFailureException with large HTTP responses due to BufferedInputStream mark/reset limitation [nifi]

2025-09-27 Thread via GitHub
ravinarayansingh opened a new pull request, #10355: URL: https://github.com/apache/nifi/pull/10355 …st mark/reset support, add related tests. # Summary [NIFI-15025](https://issues.apache.org/jira/browse/NIFI-15025) # Tra

Re: [PR] NIFI-11871: replicated polling functionality from the flow into the c… [nifi]

2025-09-27 Thread via GitHub
github-actions[bot] closed pull request #9924: NIFI-11871: replicated polling functionality from the flow into the c… URL: https://github.com/apache/nifi/pull/9924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] MINIFICPP-2629 Clean up minifi-api includes [nifi-minifi-cpp]

2025-09-27 Thread via GitHub
lordgamez commented on code in PR #2029: URL: https://github.com/apache/nifi-minifi-cpp/pull/2029#discussion_r2369375348 ## core-framework/src/utils/SystemCpuUsageTracker.cpp: ## @@ -76,7 +76,7 @@ double SystemCpuUsageTracker::getCpuUsageBetweenLastTwoQueries() const { if (t

[PR] NIFI-13009 Update documentation and ui message to better capture changes made to disconnected node [nifi]

2025-09-26 Thread via GitHub
NissimShiman opened a new pull request, #10354: URL: https://github.com/apache/nifi/pull/10354 # Summary [NIFI-13009](https://issues.apache.org/jira/browse/NIFI-13009) # Tracking Please complete the following tracking st

[PR] NIFI-15017 Add start/stop C2 command for processors in MiNiFi [nifi]

2025-09-26 Thread via GitHub
Mihhai opened a new pull request, #10353: URL: https://github.com/apache/nifi/pull/10353 # Summary [NIFI-15017](https://issues.apache.org/jira/browse/NIFI-15017) # Tracking Please complete the following tracking steps pr

Re: [PR] NIFI-15014 allow advanced UpdateAttribute Rules to be searched even i… [nifi]

2025-09-26 Thread via GitHub
pvillard31 commented on PR #10345: URL: https://github.com/apache/nifi/pull/10345#issuecomment-806218 Yeah fair point, given this is typescript, I assumed that the UI folks are more familiar with this code -- This is an automated message from the Apache Git Service. To respond to the

[PR] MINIFICPP-2638 Fix package source and gitignore lists [nifi-minifi-cpp]

2025-09-26 Thread via GitHub
lordgamez opened a new pull request, #2037: URL: https://github.com/apache/nifi-minifi-cpp/pull/2037 - Remove build_description.cpp from package source ignore list - Add asset test generated files to ignore list - Add CMakePresets.json and CMakeUserPresets.json to ignore list htt

Re: [PR] MINIFICPP-2558 Revamp site to site communication [nifi-minifi-cpp]

2025-09-26 Thread via GitHub
lordgamez commented on code in PR #1966: URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2381549857 ## libminifi/include/sitetosite/SiteToSiteClient.h: ## @@ -19,246 +19,180 @@ #pragma once #include -#include #include #include #include #include

Re: [PR] MINIFICPP-2638 Fix package source and gitignore lists [nifi-minifi-cpp]

2025-09-26 Thread via GitHub
fgerlits closed pull request #2037: MINIFICPP-2638 Fix package source and gitignore lists URL: https://github.com/apache/nifi-minifi-cpp/pull/2037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]

2025-09-26 Thread via GitHub
fgerlits commented on code in PR #1986: URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2381448847 ## libminifi/test/unit/GeneralUtilsTest.cpp: ## @@ -27,55 +27,55 @@ namespace org::apache::nifi::minifi::test { // intdiv_ceil -static_assert(0 == utils::i

Re: [PR] NIFI-15001 - Fix PutElasticsearchRecord with recursive reads [nifi]

2025-09-25 Thread via GitHub
dan-s1 commented on code in PR #10334: URL: https://github.com/apache/nifi/pull/10334#discussion_r2379424428 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchRecord.java:

[PR] NIFI-15005 route not found [nifi]

2025-09-25 Thread via GitHub
scottyaslan opened a new pull request, #10350: URL: https://github.com/apache/nifi/pull/10350 # Summary [NIFI-15005](https://issues.apache.org/jira/browse/NIFI-15005) https://github.com/user-attachments/assets/c1099db3-67cb-4b5c-bf0e-f32486b1bf48"; /> # Tracking Pleas

Re: [PR] NIFI-15004 nifi registry about dialog [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10347: URL: https://github.com/apache/nifi/pull/10347#discussion_r2380292986 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/about.service.ts: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] NIFI-15004 nifi registry about dialog [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10347: URL: https://github.com/apache/nifi/pull/10347#discussion_r2380262296 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/about.service.ts: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] NIFI-15004 nifi registry about dialog [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10347: URL: https://github.com/apache/nifi/pull/10347#discussion_r2380262296 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/about.service.ts: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] NIFI-15004 nifi registry about dialog [nifi]

2025-09-25 Thread via GitHub
sardell commented on PR #10347: URL: https://github.com/apache/nifi/pull/10347#issuecomment-3335401254 Reviewing now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10346: URL: https://github.com/apache/nifi/pull/10346#discussion_r2379890984 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/buckets.service.ts: ## @@ -37,6 +39,61 @@ export class BucketsService { // }); //

Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]

2025-09-25 Thread via GitHub
szaszm commented on code in PR #1986: URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379880066 ## libminifi/test/unit/GeneralUtilsTest.cpp: ## Review Comment: What changed that made the `minifi::` prefix necessary? If it's not necessary, I prefer not

Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]

2025-09-25 Thread via GitHub
szaszm commented on code in PR #1986: URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379877605 ## libminifi/test/unit/GeneralUtilsTest.cpp: ## @@ -27,55 +27,55 @@ namespace org::apache::nifi::minifi::test { // intdiv_ceil -static_assert(0 == utils::int

Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]

2025-09-25 Thread via GitHub
fgerlits commented on code in PR #1986: URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379810881 ## libminifi/test/unit/GeneralUtilsTest.cpp: ## @@ -27,55 +27,55 @@ namespace org::apache::nifi::minifi::test { // intdiv_ceil -static_assert(0 == utils::i

Re: [PR] NIFI-15012 - FlowDifferenceFilters - fix handling of createControllerService() [nifi]

2025-09-25 Thread via GitHub
bbende merged PR #10342: URL: https://github.com/apache/nifi/pull/10342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10346: URL: https://github.com/apache/nifi/pull/10346#discussion_r2379713723 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/buckets/feature/ui/bucket-table-filter/bucket-table-filter.component.ts: ## @@ -0,0 +1,103 @@ +/* + *

[PR] NIFI-15021 - Support custom form parameters in StandardOauth2AccessTokenProvider [nifi]

2025-09-25 Thread via GitHub
pvillard31 opened a new pull request, #10352: URL: https://github.com/apache/nifi/pull/10352 # Summary NIFI-15021 - Support custom form parameters in `StandardOauth2AccessTokenProvider` Similar to what we have in `JWTBearerOAuth2AccessTokenProvider`, we should support dynamic

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10346: URL: https://github.com/apache/nifi/pull/10346#discussion_r2379685316 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/buckets/feature/ui/bucket-table-filter/bucket-table-filter.component.ts: ## @@ -0,0 +1,103 @@ +/* + *

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-25 Thread via GitHub
sardell commented on code in PR #10346: URL: https://github.com/apache/nifi/pull/10346#discussion_r2379662043 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/app-routing.module.ts: ## @@ -28,13 +28,16 @@ const routes: Routes = [ path: 'explorer',

Re: [PR] MINIFICPP-2558 Revamp site to site communication [nifi-minifi-cpp]

2025-09-25 Thread via GitHub
szaszm commented on code in PR #1966: URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2351674789 ## libminifi/include/sitetosite/SiteToSiteClient.h: ## @@ -19,246 +19,180 @@ #pragma once #include -#include #include #include #include #include #

Re: [PR] NIFI-15001 - Fix PutElasticsearchRecord with recursive reads [nifi]

2025-09-25 Thread via GitHub
pvillard31 commented on code in PR #10334: URL: https://github.com/apache/nifi/pull/10334#discussion_r2379579949 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchRecord.java:

Re: [PR] NIFI-15010 - FlowDifferenceFilters - better handle property renaming [nifi]

2025-09-25 Thread via GitHub
bbende merged PR #10340: URL: https://github.com/apache/nifi/pull/10340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o

[PR] NIFI-14990 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundle nifi-elasticsearch-bundle. [nifi]

2025-09-25 Thread via GitHub
dan-s1 opened a new pull request, #10351: URL: https://github.com/apache/nifi/pull/10351 # Summary [NIFI-14990](https://issues.apache.org/jira/browse/NIFI-14990) # Tracking Please complete the following tracking steps pr

Re: [PR] NIFI-14320 buckets listing and management, (manage bucket policies is… [nifi]

2025-09-25 Thread via GitHub
sardell commented on PR #10346: URL: https://github.com/apache/nifi/pull/10346#issuecomment-3334675801 Reviewing now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] MINIFICPP-2614 Add more authentication options to Azure processors [nifi-minifi-cpp]

2025-09-25 Thread via GitHub
lordgamez commented on code in PR #2016: URL: https://github.com/apache/nifi-minifi-cpp/pull/2016#discussion_r2379485860 ## extensions/azure/controllerservices/AzureStorageCredentialsService.cpp: ## @@ -29,6 +29,10 @@ void AzureStorageCredentialsService::initialize() { } voi

Re: [PR] MINIFICPP-2614 Add more authentication options to Azure processors [nifi-minifi-cpp]

2025-09-25 Thread via GitHub
fgerlits commented on code in PR #2016: URL: https://github.com/apache/nifi-minifi-cpp/pull/2016#discussion_r2378951626 ## extensions/azure/controllerservices/AzureStorageCredentialsService.cpp: ## @@ -29,6 +29,10 @@ void AzureStorageCredentialsService::initialize() { } void

Re: [PR] NIFI-15001 - Fix PutElasticsearchRecord with recursive reads [nifi]

2025-09-25 Thread via GitHub
pvillard31 commented on code in PR #10334: URL: https://github.com/apache/nifi/pull/10334#discussion_r2379363843 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchRecord.java:

Re: [PR] NIFI-15001 - Fix PutElasticsearchRecord with recursive reads [nifi]

2025-09-25 Thread via GitHub
dan-s1 commented on code in PR #10334: URL: https://github.com/apache/nifi/pull/10334#discussion_r2379276797 ## nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchRecord.java:

Re: [PR] NIFI-15014 allow advanced UpdateAttribute Rules to be searched even i… [nifi]

2025-09-25 Thread via GitHub
markobean commented on PR #10345: URL: https://github.com/apache/nifi/pull/10345#issuecomment-780219 @pvillard31 This issue is not directly related to the UI; I'm not sure the label is appropriate. While the search functionality is accessed through the UI, the only update is in the back

[PR] NIFI-15015 - Bump Commons Lang3 to 3.19.0, H2 to 2.4.240, Datafaker to 2.5.1, and others [nifi]

2025-09-25 Thread via GitHub
pvillard31 opened a new pull request, #10349: URL: https://github.com/apache/nifi/pull/10349 # Summary NIFI-15015 - Bump Commons Lang3 to 3.19.0, H2 to 2.4.240, Datafaker to 2.5.1, and others - Spotbugs Maven Plugin from 4.9.5.0 to 4.9.6.0 - https://github.com/spotbugs/spotbug

Re: [PR] NIFI-15009 Codemirror json highlighting [nifi]

2025-09-24 Thread via GitHub
rfellows merged PR #10339: URL: https://github.com/apache/nifi/pull/10339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache

[PR] NIFI-15007 add link to documentation in global menu [nifi]

2025-09-24 Thread via GitHub
scottyaslan opened a new pull request, #10348: URL: https://github.com/apache/nifi/pull/10348 # Summary [NIFI-15007](https://issues.apache.org/jira/browse/NIFI-15007) link to nifi registry documentation. https://github.com/user-attachments/assets/5fa2861d-dacc-430d-9a6d-6ef3a8c

[PR] NIFI-15004 nifi registry about dialog [nifi]

2025-09-24 Thread via GitHub
scottyaslan opened a new pull request, #10347: URL: https://github.com/apache/nifi/pull/10347 # Summary [NIFI-15004](https://issues.apache.org/jira/browse/NIFI-15004) https://github.com/user-attachments/assets/c349ee0a-3486-4686-b763-421b7284eb0a"; /> # Tracking

[PR] NIFI-15012 - FlowDifferenceFilters - fix handling of createControllerService() [nifi]

2025-09-24 Thread via GitHub
pvillard31 opened a new pull request, #10342: URL: https://github.com/apache/nifi/pull/10342 # Summary NIFI-15012 - FlowDifferenceFilters - fix handling of createControllerService() In [NIFI-14995](https://issues.apache.org/jira/browse/NIFI-14995), we tried to properly handle

Re: [PR] MINIFICPP-2637 Upgrade libxml2 to v2.15.0 [nifi-minifi-cpp]

2025-09-24 Thread via GitHub
szaszm commented on code in PR #2036: URL: https://github.com/apache/nifi-minifi-cpp/pull/2036#discussion_r2376155639 ## cmake/LibXml2.cmake: ## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOT

Re: [PR] MINIFICPP-2637 Upgrade libxml2 to v2.15.0 [nifi-minifi-cpp]

2025-09-24 Thread via GitHub
szaszm commented on code in PR #2036: URL: https://github.com/apache/nifi-minifi-cpp/pull/2036#discussion_r2376153364 ## cmake/LibXml2.cmake: ## Review Comment: Now that it's changed to FetchContent, we should stop referencing libxml2 from the main CMakeLists.txt, and only

Re: [PR] MINIFICPP-2637 Upgrade libxml2 to v2.15.0 [nifi-minifi-cpp]

2025-09-24 Thread via GitHub
szaszm commented on code in PR #2036: URL: https://github.com/apache/nifi-minifi-cpp/pull/2036#discussion_r2376153364 ## cmake/LibXml2.cmake: ## Review Comment: Now that it's changed to FetchContent, we should stop referencing libxml2 from the main CMakeLists.txt, and only

Re: [PR] MINIFICPP-2637 Upgrade libxml2 to v2.15.0 [nifi-minifi-cpp]

2025-09-24 Thread via GitHub
fgerlits commented on code in PR #2036: URL: https://github.com/apache/nifi-minifi-cpp/pull/2036#discussion_r2376086865 ## cmake/AzureSdkCpp.cmake: ## @@ -55,3 +55,8 @@ FetchContent_Declare(asdkext ) FetchContent_MakeAvailable(asdkext) + +if (NOT WIN32) +add_dependencies

[PR] MINIFICPP-2637 Upgrade libxml2 to v2.15.0 [nifi-minifi-cpp]

2025-09-24 Thread via GitHub
lordgamez opened a new pull request, #2036: URL: https://github.com/apache/nifi-minifi-cpp/pull/2036 https://issues.apache.org/jira/browse/MINIFICPP-2637 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline th

Re: [PR] MINIFICPP-2635 Handle dynamic properties correctly in python processors [nifi-minifi-cpp]

2025-09-24 Thread via GitHub
martinzink closed pull request #2034: MINIFICPP-2635 Handle dynamic properties correctly in python processors URL: https://github.com/apache/nifi-minifi-cpp/pull/2034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] NIFI-14953 Validate inlined protobuf schemas [nifi]

2025-09-23 Thread via GitHub
lkuchars commented on code in PR #10291: URL: https://github.com/apache/nifi/pull/10291#discussion_r2373544878 ## nifi-extension-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/StandardProtobufReader.java: ## @@ -170,6 +174,84

Re: [PR] NIFI-14953 Validate inlined protobuf schemas [nifi]

2025-09-23 Thread via GitHub
lkuchars commented on code in PR #10291: URL: https://github.com/apache/nifi/pull/10291#discussion_r2373543832 ## nifi-extension-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/test/java/org/apache/nifi/services/protobuf/TestStandardProtobufReaderPropertyValidation.java: ###

Re: [PR] NIFI-14953 Validate inlined protobuf schemas [nifi]

2025-09-23 Thread via GitHub
lkuchars commented on code in PR #10291: URL: https://github.com/apache/nifi/pull/10291#discussion_r2373543562 ## nifi-extension-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/java/org/apache/nifi/services/protobuf/ProtobufSchemaCompiler.java: ## @@ -129,7 +129,8 @

Re: [PR] NIFI-14953 Validate inlined protobuf schemas [nifi]

2025-09-23 Thread via GitHub
lkuchars closed pull request #10291: NIFI-14953 Validate inlined protobuf schemas URL: https://github.com/apache/nifi/pull/10291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] NIFI-15008 Allow affected components to be reloaded if necessary duri… [nifi]

2025-09-23 Thread via GitHub
bbende opened a new pull request, #10338: URL: https://github.com/apache/nifi/pull/10338 …ng parameter context update # Summary [NIFI-15008](https://issues.apache.org/jira/browse/NIFI-15008) Allow affected components to

Re: [PR] NIFI-14319: Create initial project structure for new NiFi Registry UI [nifi]

2025-09-23 Thread via GitHub
scottyaslan merged PR #9855: URL: https://github.com/apache/nifi/pull/9855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apach

Re: [PR] MINIFICPP-2635 Handle dynamic properties correctly in python processors [nifi-minifi-cpp]

2025-09-23 Thread via GitHub
fgerlits commented on code in PR #2034: URL: https://github.com/apache/nifi-minifi-cpp/pull/2034#discussion_r2371923043 ## PROCESSORS.md: ## @@ -722,7 +722,7 @@ In the list below, the names of required properties appear in bold. Any other pr ### Description -Executes a scr

Re: [PR] MINIFICPP-2629 Clean up minifi-api includes [nifi-minifi-cpp]

2025-09-23 Thread via GitHub
szaszm commented on code in PR #2029: URL: https://github.com/apache/nifi-minifi-cpp/pull/2029#discussion_r2368628272 ## extensions/systemd/ConsumeJournald.cpp: ## @@ -78,7 +78,7 @@ void ConsumeJournald::onSchedule(core::ProcessContext& context, core::ProcessSes return pro

Re: [PR] MINIFICPP-2629 Clean up minifi-api includes [nifi-minifi-cpp]

2025-09-23 Thread via GitHub
szaszm commented on code in PR #2029: URL: https://github.com/apache/nifi-minifi-cpp/pull/2029#discussion_r2371999120 ## extensions/sftp/processors/ListSFTP.cpp: ## @@ -690,7 +690,7 @@ void ListSFTP::listByTrackingEntities( time_t now = time(nullptr); uint64_t min_timest

Re: [PR] MINIFICPP-2565 Add compression support for site to site communication [nifi-minifi-cpp]

2025-09-23 Thread via GitHub
fgerlits commented on code in PR #1974: URL: https://github.com/apache/nifi-minifi-cpp/pull/1974#discussion_r2371870968 ## SITE_TO_SITE.md: ## Review Comment: this file needs to be added to `packaging/rpm/expected-rpm-contents.in` to fix the Rocky (docker) build -- Thi

Re: [PR] NIFI-14959 fix consistent hash function for partition-by-attribute [nifi]

2025-09-23 Thread via GitHub
pvillard31 closed pull request #10336: NIFI-14959 fix consistent hash function for partition-by-attribute URL: https://github.com/apache/nifi/pull/10336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] NIFI-14319: Create initial project structure for new NiFi Registry UI [nifi]

2025-09-22 Thread via GitHub
scottyaslan commented on code in PR #9855: URL: https://github.com/apache/nifi/pull/9855#discussion_r2370420338 ## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/error-helper.service.ts: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (

[PR] NIFI-15000 Remove AzureGraphUserGroupProvider [nifi]

2025-09-22 Thread via GitHub
exceptionfactory opened a new pull request, #10335: URL: https://github.com/apache/nifi/pull/10335 # Summary [NIFI-15000](https://issues.apache.org/jira/browse/NIFI-15000) Removes the `AzureGraphUserGroupProvider` implementation of the framework User Group Provider. The Azure

Re: [PR] NIFI-14384 Adds Force Path Style support to S3 Bundle Persistence Pro… [nifi]

2025-09-22 Thread via GitHub
exceptionfactory commented on code in PR #10331: URL: https://github.com/apache/nifi/pull/10331#discussion_r2370151822 ## nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-extensions/src/test/java/org/apache/nifi/registry/aws/S3BundlePersistenceProviderIT.java:

Re: [PR] NIFI-14989 Aligned those processors and controller services whose property names do not match the human-friendly display names in extended bundles nifi-box-bundle, nifi-cdc, nifi-cipher-bundl

2025-09-22 Thread via GitHub
exceptionfactory merged PR #10328: URL: https://github.com/apache/nifi/pull/10328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] MINIFICPP-2565 Add compression support for site to site communication [nifi-minifi-cpp]

2025-09-22 Thread via GitHub
lordgamez commented on code in PR #1974: URL: https://github.com/apache/nifi-minifi-cpp/pull/1974#discussion_r2368673344 ## libminifi/include/sitetosite/CompressionConsts.h: ## @@ -0,0 +1,28 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] NIFI-14995 - Improve Flow Differences Filter to account for renameProperty and createControllerService [nifi]

2025-09-22 Thread via GitHub
pvillard31 commented on PR #10327: URL: https://github.com/apache/nifi/pull/10327#issuecomment-3321160596 Thanks for the review @exceptionfactory - I pushed a commit to address your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] NIFI-14995 - Improve Flow Differences Filter to account for renameProperty and createControllerService [nifi]

2025-09-22 Thread via GitHub
exceptionfactory commented on code in PR #10327: URL: https://github.com/apache/nifi/pull/10327#discussion_r2369816063 ## nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java: ## @@ -547,4 +577,302 @@ privat

Re: [PR] MINIFICPP-2634 Turn on building stable extensions by default [nifi-minifi-cpp]

2025-09-22 Thread via GitHub
martinzink closed pull request #2033: MINIFICPP-2634 Turn on building stable extensions by default URL: https://github.com/apache/nifi-minifi-cpp/pull/2033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   3   4   5   6   7   8   9   10   >