Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-09-28 Thread via GitHub
exceptionfactory commented on PR #8892: URL: https://github.com/apache/nifi/pull/8892#issuecomment-2380707585 @takraj Given the number of conflicts and comments outstanding, I am going to close this for now. If you can address the current merge conflicts and address the comments, feel free

Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]

2024-09-28 Thread via GitHub
exceptionfactory closed pull request #8892: NIFI-13311: Turn DB adapters into controller services URL: https://github.com/apache/nifi/pull/8892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] NIFI-13776 fixed a bug w/ CopyS3Object that prevented it from working… [nifi]

2024-09-28 Thread via GitHub
exceptionfactory commented on code in PR #9286: URL: https://github.com/apache/nifi/pull/9286#discussion_r1779607458 ## nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/CopyS3Object.java: ## @@ -119,28 +145,127 @@ public void o

Re: [PR] NIFI-13811: Fix CalculateRecordStats so that it can properly handle a… [nifi]

2024-09-28 Thread via GitHub
EndzeitBegins commented on code in PR #9321: URL: https://github.com/apache/nifi/pull/9321#discussion_r1779498415 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateRecordStats.java: ## @@ -133,104 +

[PR] [NIFI-13778] markdown syntax highlighting and h1-h5, tables, ul, and … [nifi]

2024-09-27 Thread via GitHub
scottyaslan opened a new pull request, #9323: URL: https://github.com/apache/nifi/pull/9323 …ol style updates https://github.com/user-attachments/assets/a3782841-fb32-42c5-b844-54a8e1f3eeb7";> -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] NIFI-13813 Refactor NiFi Runtime Property Loading [nifi]

2024-09-27 Thread via GitHub
exceptionfactory commented on PR #9322: URL: https://github.com/apache/nifi/pull/9322#issuecomment-2380085458 Marking as draft to review intermittent system test behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
exceptionfactory commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1779176168 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCur

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1779160056 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1779160056 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1779160056 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1779069201 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1779069201 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-27 Thread via GitHub
mosermw commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1779059364 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java: ## @@ -280,6 +280,13 @@ p

Re: [PR] NIFI-13549 Resolve ability to go to provenance event from lineage ui when nifi is clustered - 1.x issue only. Not seen on 2.x branch [nifi]

2024-09-27 Thread via GitHub
NissimShiman commented on PR #9289: URL: https://github.com/apache/nifi/pull/9289#issuecomment-2379899676 Thank you very much @mosermw for looking at this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] NIFI-13549 Resolve ability to go to provenance event from lineage ui when nifi is clustered - 1.x issue only. Not seen on 2.x branch [nifi]

2024-09-27 Thread via GitHub
mosermw closed pull request #9289: NIFI-13549 Resolve ability to go to provenance event from lineage ui when nifi is clustered - 1.x issue only. Not seen on 2.x branch URL: https://github.com/apache/nifi/pull/9289 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] NIFI-13776 fixed a bug w/ CopyS3Object that prevented it from working… [nifi]

2024-09-27 Thread via GitHub
MikeThomsen commented on PR #9286: URL: https://github.com/apache/nifi/pull/9286#issuecomment-2379850061 @exceptionfactory Pushed a bunch of updates to break it down into different strategies, simplify some of the nesting and make the retry logic configurable. @joewitt can you spot ch

Re: [PR] NIFI-13549 Resolve ability to go to provenance event from lineage ui when nifi is clustered - 1.x issue only. Not seen on 2.x branch [nifi]

2024-09-27 Thread via GitHub
mosermw commented on PR #9289: URL: https://github.com/apache/nifi/pull/9289#issuecomment-2379841463 I reviewed this and confirmed the bug fix, so +1 thanks for finding and fixing this @NissimShiman. Will merge ... I confirmed the bug occurs on a 1.x cluster and confirmed this PR fix

Re: [PR] NIFI-13810 Handle Trailing Separator for Encoded Paths in URI Builder [nifi]

2024-09-27 Thread via GitHub
asfgit closed pull request #9319: NIFI-13810 Handle Trailing Separator for Encoded Paths in URI Builder URL: https://github.com/apache/nifi/pull/9319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] NIFI-13813 Refactor NiFi Runtime Property Loading [nifi]

2024-09-27 Thread via GitHub
exceptionfactory opened a new pull request, #9322: URL: https://github.com/apache/nifi/pull/9322 # Summary [NIFI-13813](https://issues.apache.org/jira/browse/NIFI-13813) Refactors NiFi Runtime property loading and initialization handling to remove the unclear coupling to the bootstra

Re: [PR] [NIFI-13806] finalize color hues [nifi]

2024-09-27 Thread via GitHub
mcgilman merged PR #9315: URL: https://github.com/apache/nifi/pull/9315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o

[PR] NIFI-13811: Fix CalculateRecordStats so that it can properly handle a… [nifi]

2024-09-27 Thread via GitHub
markap14 opened a new pull request, #9321: URL: https://github.com/apache/nifi/pull/9321 …rrays of nested records; clarified documentation / code cleanup # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-27 Thread via GitHub
exceptionfactory commented on PR #9273: URL: https://github.com/apache/nifi/pull/9273#issuecomment-2379524999 Thanks @mattyb149, I will take another look and follow up soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] NIFI-13721: Migrating documentation into the NiFi UI [nifi]

2024-09-27 Thread via GitHub
scottyaslan merged PR #9288: URL: https://github.com/apache/nifi/pull/9288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apach

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-27 Thread via GitHub
mattyb149 commented on PR #9273: URL: https://github.com/apache/nifi/pull/9273#issuecomment-2379506092 +1 LGTM, verified the expected behavior. @exceptionfactory do you want another look at this? If not I'll merge -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] NIFI-13724 Add additional metadata to Registry events [nifi]

2024-09-27 Thread via GitHub
bbende commented on code in PR #9239: URL: https://github.com/apache/nifi/pull/9239#discussion_r1778749488 ## nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/event/EventFactory.java: ## @@ -70,7 +88,12 @@ public static Event flowUp

[PR] NIFI-13812 [MiNiFi][C2] Add component type into Agent Manifest Hash calculation [nifi]

2024-09-27 Thread via GitHub
ferencerdei opened a new pull request, #9320: URL: https://github.com/apache/nifi/pull/9320 Add component type into Agent Manifest Hash calculation # Summary [NIFI-13812](https://issues.apache.org/jira/browse/NIFI-13812)

[PR] NIFI-13810 Handle Trailing Separator for Encoded Paths in URI Builder [nifi]

2024-09-27 Thread via GitHub
exceptionfactory opened a new pull request, #9319: URL: https://github.com/apache/nifi/pull/9319 # Summary [NIFI-13810](https://issues.apache.org/jira/browse/NIFI-13810) Updates the `StandardHttpUriBuilder` in `nifi-web-client` to handle the need for a path segment separator when add

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1778571127 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] NIFI-13644 Add GitLab Flow Registry Client [nifi]

2024-09-27 Thread via GitHub
bbende commented on PR #9264: URL: https://github.com/apache/nifi/pull/9264#issuecomment-2379332101 Thanks @exceptionfactory , pushed an update to address your suggestions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] NIFI-13798: Update Airtable docs with PATs due to API Keys deprecation [nifi]

2024-09-27 Thread via GitHub
turcsanyip commented on code in PR #9308: URL: https://github.com/apache/nifi/pull/9308#discussion_r1778657350 ## nifi-extension-bundles/nifi-airtable-bundle/nifi-airtable-processors/src/main/java/org/apache/nifi/processors/airtable/QueryAirtableTable.java: ## @@ -108,10 +109,10

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-27 Thread via GitHub
dan-s1 commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1778571127 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -127,17 +134,6 @@ private Map getCurrentRowVal

Re: [PR] MINIFICPP-2279 Add support for RecordTransform NiFi python processors [nifi-minifi-cpp]

2024-09-27 Thread via GitHub
lordgamez commented on code in PR #1863: URL: https://github.com/apache/nifi-minifi-cpp/pull/1863#discussion_r1778180603 ## extensions/python/types/PyRecordSetReader.cpp: ## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-26 Thread via GitHub
exceptionfactory commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1777832185 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java: ## @@ -280,6 +28

Re: [PR] NIFI-13644 Add GitLab Flow Registry Client [nifi]

2024-09-26 Thread via GitHub
exceptionfactory commented on code in PR #9264: URL: https://github.com/apache/nifi/pull/9264#discussion_r1777839841 ## nifi-extension-bundles/nifi-extension-utils/nifi-git-flow-registry/src/main/java/org/apache/nifi/registry/flow/git/AbstractGitFlowRegistryClient.java: ## @@ -0

Re: [PR] NIFI-13809 Upgrade maven-archetype-plugin from 3.2.1 to 3.3.0 [nifi]

2024-09-26 Thread via GitHub
exceptionfactory merged PR #9318: URL: https://github.com/apache/nifi/pull/9318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

[PR] Bump org.apache.maven.plugins:maven-archetype-plugin from 3.2.1 to 3.3.0 in /nifi-maven-archetypes/nifi-processor-bundle-archetype [nifi]

2024-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #9318: URL: https://github.com/apache/nifi/pull/9318 Bumps [org.apache.maven.plugins:maven-archetype-plugin](https://github.com/apache/maven-archetype) from 3.2.1 to 3.3.0. Release notes Sourced from https://github.com/apache/maven-archet

Re: [PR] NIFI-13779: Missing Some Data Provenance Events from Python [nifi]

2024-09-26 Thread via GitHub
exceptionfactory merged PR #9292: URL: https://github.com/apache/nifi/pull/9292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-13795 Improve NAR Manager handling of dependent NARs [nifi]

2024-09-26 Thread via GitHub
exceptionfactory merged PR #9310: URL: https://github.com/apache/nifi/pull/9310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] MINIFICPP-2460 Add tests for S2S tests using SSL [nifi-minifi-cpp]

2024-09-26 Thread via GitHub
szaszm closed pull request #1869: MINIFICPP-2460 Add tests for S2S tests using SSL URL: https://github.com/apache/nifi-minifi-cpp/pull/1869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] MINIFICPP-2453 Add yield function support to python API [nifi-minifi-cpp]

2024-09-26 Thread via GitHub
szaszm closed pull request #1865: MINIFICPP-2453 Add yield function support to python API URL: https://github.com/apache/nifi-minifi-cpp/pull/1865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINIFICPP-2456 Remove curl output from Elasticsearch responses [nifi-minifi-cpp]

2024-09-26 Thread via GitHub
szaszm closed pull request #1867: MINIFICPP-2456 Remove curl output from Elasticsearch responses URL: https://github.com/apache/nifi-minifi-cpp/pull/1867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINIFICPP-2447 Include the Python processor version in the manifest [nifi-minifi-cpp]

2024-09-26 Thread via GitHub
szaszm closed pull request #1861: MINIFICPP-2447 Include the Python processor version in the manifest URL: https://github.com/apache/nifi-minifi-cpp/pull/1861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] NIFI-13807: Ensure that we always close InputStream / OutputSTrema fo… [nifi]

2024-09-26 Thread via GitHub
exceptionfactory merged PR #9316: URL: https://github.com/apache/nifi/pull/9316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

[PR] NIFI-13803 Improve loading of flow when clustered to only sync into t… [nifi]

2024-09-26 Thread via GitHub
bbende opened a new pull request, #9317: URL: https://github.com/apache/nifi/pull/9317 …he coordinator after getting cluster response # Summary [NIFI-13803](https://issues.apache.org/jira/browse/NIFI-13803) Previously wh

Re: [PR] NIFI-13779: Missing Some Data Provenance Events from Python [nifi]

2024-09-26 Thread via GitHub
bobpaulin commented on PR #9292: URL: https://github.com/apache/nifi/pull/9292#issuecomment-2377340504 Thanks @markap14 and @exceptionfactory as always for the feedback. This cleaned up nicely with the usage of `isAutoTerminated` will look forward to using that more! -- This is

[PR] NIFI-13807: Ensure that we always close InputStream / OutputSTrema fo… [nifi]

2024-09-26 Thread via GitHub
markap14 opened a new pull request, #9316: URL: https://github.com/apache/nifi/pull/9316 …r HttpExchange. Verified fix using InvokeHTTP to hit the health endpoint hundreds of thousands of times and verified NiFi heap usage was still at 200 MB after a young GC event

Re: [PR] MINIFICPP-2279 Add support for RecordTransform NiFi python processors [nifi-minifi-cpp]

2024-09-26 Thread via GitHub
szaszm commented on code in PR #1863: URL: https://github.com/apache/nifi-minifi-cpp/pull/1863#discussion_r1777221590 ## extensions/python/types/PyRecordSetReader.cpp: ## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

Re: [PR] NIFI-13779: Missing Some Data Provenance Events from Python [nifi]

2024-09-26 Thread via GitHub
exceptionfactory commented on code in PR #9292: URL: https://github.com/apache/nifi/pull/9292#discussion_r1777131916 ## nifi-extension-bundles/nifi-py4j-extension-bundle/nifi-py4j-bridge/src/main/java/org/apache/nifi/python/processor/FlowFileTransformProxy.java: ## @@ -40,22 +40

Re: [PR] NIFI-13779: Missing Some Data Provenance Events from Python [nifi]

2024-09-26 Thread via GitHub
markap14 commented on PR #9292: URL: https://github.com/apache/nifi/pull/9292#issuecomment-2377035357 Thanks for pinging @exceptionfactory. I do agree with the approach but think we should clean it up a bit more, as noted above. -- This is an automated message from the Apache Git Service.

Re: [PR] NIFI-13779: Missing Some Data Provenance Events from Python [nifi]

2024-09-26 Thread via GitHub
markap14 commented on code in PR #9292: URL: https://github.com/apache/nifi/pull/9292#discussion_r1777113039 ## nifi-extension-bundles/nifi-py4j-extension-bundle/nifi-py4j-bridge/src/main/java/org/apache/nifi/python/processor/FlowFileTransformProxy.java: ## @@ -40,22 +40,22 @@ p

Re: [PR] NIFI-13804 Migrate to NiFi API 2.0.0 and NAR Plugin 2.1.0 [nifi]

2024-09-26 Thread via GitHub
asfgit closed pull request #9314: NIFI-13804 Migrate to NiFi API 2.0.0 and NAR Plugin 2.1.0 URL: https://github.com/apache/nifi/pull/9314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] NIFI-13804 Migrate to NiFi API 2.0.0 and NAR Plugin 2.1.0 [nifi]

2024-09-26 Thread via GitHub
joewitt commented on PR #9314: URL: https://github.com/apache/nifi/pull/9314#issuecomment-2376335877 wow - pretty weird to see this when you consider the very first thing that really ever ended up in this source tree was the 'nifi-api' folder! Pre apache open sourcing no less. +1 me

[PR] NIFI-13804 Migrate to NiFi API 2.0.0 and NAR Plugin 2.1.0 [nifi]

2024-09-25 Thread via GitHub
exceptionfactory opened a new pull request, #9314: URL: https://github.com/apache/nifi/pull/9314 # Summary [NIFI-13804](https://issues.apache.org/jira/browse/NIFI-13804) Migrates the repository to version [2.0.0](https://github.com/apache/nifi-api/releases/tag/nifi-api-2.0.0) of the

Re: [PR] NIFI-12992: When updating Execution Engine of a Process Group, reset … [nifi]

2024-09-25 Thread via GitHub
exceptionfactory merged PR #9187: URL: https://github.com/apache/nifi/pull/9187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-13799 Improve Replicated Cluster Response Handling [nifi]

2024-09-25 Thread via GitHub
markap14 merged PR #9312: URL: https://github.com/apache/nifi/pull/9312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o

Re: [PR] NIFI-13799 Improve Replicated Cluster Response Handling [nifi]

2024-09-25 Thread via GitHub
markap14 commented on PR #9312: URL: https://github.com/apache/nifi/pull/9312#issuecomment-2374939560 Thanks for fixing that @exceptionfactory! Code changes look good, even a little bit of obvious cleanup that was necessary, likely that was missed during some old refactoring :) Was able to

Re: [PR] NIFI-12992: When updating Execution Engine of a Process Group, reset … [nifi]

2024-09-25 Thread via GitHub
markap14 commented on PR #9187: URL: https://github.com/apache/nifi/pull/9187#issuecomment-2374934511 Thanks for noting the failure @exceptionfactory . I pushed a new update. The code was causing processor validation to be reset ('VALIDATING') but the processor was already running. Since it

Re: [PR] [NIFI-13797] - Fix: Bug rendering canvas when deleting a component th… [nifi]

2024-09-25 Thread via GitHub
scottyaslan merged PR #9307: URL: https://github.com/apache/nifi/pull/9307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apach

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-25 Thread via GitHub
mosermw commented on PR #9304: URL: https://github.com/apache/nifi/pull/9304#issuecomment-2374518797 > > I very much appreciate your review @exceptionfactory. I could not quite decide whether to use "header" or "headers" in the naming and description. Although RFC-6585 says the size limit c

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-25 Thread via GitHub
exceptionfactory commented on PR #9304: URL: https://github.com/apache/nifi/pull/9304#issuecomment-2374475641 > I very much appreciate your review @exceptionfactory. I could not quite decide whether to use "header" or "headers" in the naming and description. Although RFC-6585 says the size

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-25 Thread via GitHub
mosermw commented on PR #9304: URL: https://github.com/apache/nifi/pull/9304#issuecomment-2374439393 I very much appreciate your review @exceptionfactory. I could not quite decide whether to use "header" or "headers" in the naming and description. Although RFC-6585 says the size limit can

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-25 Thread via GitHub
mosermw commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1775459998 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java: ## @@ -280,6 +280,13 @@ p

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-25 Thread via GitHub
mosermw commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1775458918 ## nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java: ## @@ -68,6 +68,8 @@ public class

Re: [PR] NIFI-13644 Add GitLab Flow Registry Client [nifi]

2024-09-25 Thread via GitHub
bbende commented on PR #9264: URL: https://github.com/apache/nifi/pull/9264#issuecomment-2374367388 Pushed another update to address the additional feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [NIFI-13797] - Fix: Bug rendering canvas when deleting a component th… [nifi]

2024-09-25 Thread via GitHub
rfellows commented on code in PR #9307: URL: https://github.com/apache/nifi/pull/9307#discussion_r1775138836 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts: ## @@ -268,7 +270,7 @@ export class CanvasUtils { public ca

Re: [PR] MINIFICPP-2279 Add support for RecordTransform NiFi python processors [nifi-minifi-cpp]

2024-09-25 Thread via GitHub
lordgamez commented on code in PR #1863: URL: https://github.com/apache/nifi-minifi-cpp/pull/1863#discussion_r1775092411 ## extensions/python/types/PyProcessSession.h: ## @@ -39,6 +39,7 @@ class PyProcessSession { void remove(const std::shared_ptr& flow_file); std::string

Re: [PR] MINIFICPP-2279 Add support for RecordTransform NiFi python processors [nifi-minifi-cpp]

2024-09-25 Thread via GitHub
lordgamez commented on code in PR #1863: URL: https://github.com/apache/nifi-minifi-cpp/pull/1863#discussion_r1775091943 ## extensions/python/types/PyRecordSetReader.cpp: ## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] MINIFICPP-2460 Add tests for S2S tests using SSL [nifi-minifi-cpp]

2024-09-25 Thread via GitHub
szaszm commented on code in PR #1869: URL: https://github.com/apache/nifi-minifi-cpp/pull/1869#discussion_r1775080633 ## libminifi/src/RemoteProcessorGroupPort.cpp: ## @@ -292,6 +292,7 @@ std::pair RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo if (!token.empty())

Re: [PR] MINIFICPP-2279 Add support for RecordTransform NiFi python processors [nifi-minifi-cpp]

2024-09-25 Thread via GitHub
lordgamez commented on code in PR #1863: URL: https://github.com/apache/nifi-minifi-cpp/pull/1863#discussion_r1775067158 ## extensions/python/types/PyProcessSession.cpp: ## @@ -178,14 +178,24 @@ PyObject* PyProcessSessionObject::get(PyProcessSessionObject* self, PyObject*) {

Re: [PR] MINIFICPP-2279 Add support for RecordTransform NiFi python processors [nifi-minifi-cpp]

2024-09-25 Thread via GitHub
szaszm commented on code in PR #1863: URL: https://github.com/apache/nifi-minifi-cpp/pull/1863#discussion_r1775039492 ## extensions/python/types/PyProcessSession.h: ## @@ -39,6 +39,7 @@ class PyProcessSession { void remove(const std::shared_ptr& flow_file); std::string get

Re: [PR] NIFI-13802: Renamed system tests to ensure that they end in IT. Also … [nifi]

2024-09-24 Thread via GitHub
exceptionfactory merged PR #9313: URL: https://github.com/apache/nifi/pull/9313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-13801: Fixed counter for ConsumeKafka to correctly indicate numb… [nifi]

2024-09-24 Thread via GitHub
asfgit closed pull request #9311: NIFI-13801: Fixed counter for ConsumeKafka to correctly indicate numb… URL: https://github.com/apache/nifi/pull/9311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] NIFI-13802: Renamed system tests to ensure that they end in IT. Also … [nifi]

2024-09-24 Thread via GitHub
markap14 opened a new pull request, #9313: URL: https://github.com/apache/nifi/pull/9313 …a bit of cleanup in the system tests and ensure that the RestartWithDifferentPort test does not allow instance reuse, since it changes the nifi port, which can cause subsequent tests to fail if they us

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-24 Thread via GitHub
exceptionfactory commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1774132325 ## nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/StandardServerConnectorFactory.java: ## @@ -68,6 +68,8 @@ pub

Re: [PR] NIFI-13744 2.x Resolved ExcelReader time conversion issues by ensuring the same string value used for determining the record field type is the same value used for reading the record value. [n

2024-09-24 Thread via GitHub
exceptionfactory commented on code in PR #9290: URL: https://github.com/apache/nifi/pull/9290#discussion_r1774127351 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelRecordReader.java: ## @@ -45,8 +46,14 @@ public class ExcelRe

Re: [PR] NIFI-13800: When inheriting Registry Clients from a cluster's flow, a… [nifi]

2024-09-24 Thread via GitHub
exceptionfactory merged PR #9309: URL: https://github.com/apache/nifi/pull/9309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-24 Thread via GitHub
mosermw commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1774117077 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java: ## @@ -380,7 +388,19 @@ s

Re: [PR] NIFI-13781 Updated DataTypeUtils with enhanced switch statements, pattern variables and some other minor formatting changes. [nifi]

2024-09-24 Thread via GitHub
exceptionfactory merged PR #9302: URL: https://github.com/apache/nifi/pull/9302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-12762 allow for increasing max size of request headers in ListenHTTP and HandleHttpRequest [nifi]

2024-09-24 Thread via GitHub
mosermw commented on code in PR #9304: URL: https://github.com/apache/nifi/pull/9304#discussion_r1774118647 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java: ## @@ -380,7 +388,19 @@ s

[PR] NIFI-13799 Improve Replicated Cluster Response Handling [nifi]

2024-09-24 Thread via GitHub
exceptionfactory opened a new pull request, #9312: URL: https://github.com/apache/nifi/pull/9312 # Summary [NIFI-13799](https://issues.apache.org/jira/browse/NIFI-13799) Improves replicated HTTP response handling for requests to cluster nodes, avoiding potential heap exhaustion when

Re: [PR] NIFI-13798: Update Airtable docs with PATs due to API Keys deprecation [nifi]

2024-09-24 Thread via GitHub
turcsanyip commented on code in PR #9308: URL: https://github.com/apache/nifi/pull/9308#discussion_r1774009451 ## nifi-extension-bundles/nifi-airtable-bundle/nifi-airtable-processors/src/main/java/org/apache/nifi/processors/airtable/QueryAirtableTable.java: ## @@ -108,10 +108,11

Re: [PR] NIFI-13801: Fixed counter for ConsumeKafka to correctly indicate numb… [nifi]

2024-09-24 Thread via GitHub
joewitt commented on PR #9311: URL: https://github.com/apache/nifi/pull/9311#issuecomment-2372266935 huge thanks. will let the tests run and do a local build in a few hours. but super helpful thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] NIFI-13801: Fixed counter for ConsumeKafka to correctly indicate numb… [nifi]

2024-09-24 Thread via GitHub
markap14 opened a new pull request, #9311: URL: https://github.com/apache/nifi/pull/9311 …er of messages received using using a demarcator # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracki

[PR] NIFI-13795 Improve NAR Manager handling of dependent NARs [nifi]

2024-09-24 Thread via GitHub
bbende opened a new pull request, #9310: URL: https://github.com/apache/nifi/pull/9310 - Ensure NARs are loaded in parent-first order during restart - Allow replacing a NAR when other NARs are dependent on it - Improvements to catch `Throwable` in several places to handle `NoClassDefFo

Re: [PR] NIFI-13724 Add additional metadata to Registry events [nifi]

2024-09-24 Thread via GitHub
Dye357 commented on PR #9239: URL: https://github.com/apache/nifi/pull/9239#issuecomment-2371969044 Does anyone have some time to review the PR I submitted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] NIFI-13800: When inheriting Registry Clients from a cluster's flow, a… [nifi]

2024-09-24 Thread via GitHub
markap14 opened a new pull request, #9309: URL: https://github.com/apache/nifi/pull/9309 …ny missing registry clients are removed at the end instead of the beginning of the synchronization logic. This allows those registry clients to still be referenced while performing synchronization. Als

Re: [PR] NIFI-13798: Update Airtable docs with PATs due to API Keys deprecation [nifi]

2024-09-24 Thread via GitHub
turcsanyip commented on PR #9308: URL: https://github.com/apache/nifi/pull/9308#issuecomment-2371738236 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] NIFI-13798: Update Airtable docs with PATs due to API Keys deprecation [nifi]

2024-09-24 Thread via GitHub
Lehel44 opened a new pull request, #9308: URL: https://github.com/apache/nifi/pull/9308 # Summary [NIFI-13798](https://issues.apache.org/jira/browse/NIFI-13798) # Tracking Please complete the following tracking steps pri

Re: [PR] [NIFI-13797] - Fix: Bug rendering canvas when deleting a component th… [nifi]

2024-09-24 Thread via GitHub
scottyaslan commented on code in PR #9307: URL: https://github.com/apache/nifi/pull/9307#discussion_r1773419524 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts: ## @@ -268,7 +270,7 @@ export class CanvasUtils { public

[PR] MINIFICPP-2460 Add tests for S2S tests using SSL [nifi-minifi-cpp]

2024-09-24 Thread via GitHub
lordgamez opened a new pull request, #1869: URL: https://github.com/apache/nifi-minifi-cpp/pull/1869 - Add tests with both yml and json config, and with both controller property and minifi.properties file configuration - Fix RPG port properties with JSON flow config - Add verbose curl

Re: [PR] NIFI-13722: Kerberos ticket renewal issue due static thread pool in Iceberg library (nifi-1.x) [nifi]

2024-09-24 Thread via GitHub
turcsanyip commented on PR #9305: URL: https://github.com/apache/nifi/pull/9305#issuecomment-2371084405 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] NIFI-13722: Kerberos ticket renewal issue due static thread pool in Iceberg library (nifi-1.x) [nifi]

2024-09-24 Thread via GitHub
turcsanyip closed pull request #9305: NIFI-13722: Kerberos ticket renewal issue due static thread pool in Iceberg library (nifi-1.x) URL: https://github.com/apache/nifi/pull/9305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] NIFI-13720: Component is not reloaded when the isolation key depends on service property (nifi-1.x) [nifi]

2024-09-24 Thread via GitHub
turcsanyip commented on PR #9303: URL: https://github.com/apache/nifi/pull/9303#issuecomment-2370901764 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] NIFI-13720: Component is not reloaded when the isolation key depends on service property (nifi-1.x) [nifi]

2024-09-24 Thread via GitHub
turcsanyip closed pull request #9303: NIFI-13720: Component is not reloaded when the isolation key depends on service property (nifi-1.x) URL: https://github.com/apache/nifi/pull/9303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] NIFI-13762 Expose processor metrics as a part of FlowInfo [nifi]

2024-09-24 Thread via GitHub
briansolo1985 closed pull request #9281: NIFI-13762 Expose processor metrics as a part of FlowInfo URL: https://github.com/apache/nifi/pull/9281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] NIFI-13762 Expose processor metrics as a part of FlowInfo [nifi]

2024-09-24 Thread via GitHub
briansolo1985 commented on PR #9281: URL: https://github.com/apache/nifi/pull/9281#issuecomment-2370559946 thanks for the changes. going to proceed with the merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] NIFI-13358 - NiFi Registry - rework action menus for flows and bundles [nifi]

2024-09-24 Thread via GitHub
ferencerdei closed pull request #8924: NIFI-13358 - NiFi Registry - rework action menus for flows and bundles URL: https://github.com/apache/nifi/pull/8924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] NIFI-13358 - NiFi Registry - rework action menus for flows and bundles [nifi]

2024-09-24 Thread via GitHub
ferencerdei commented on PR #8924: URL: https://github.com/apache/nifi/pull/8924#issuecomment-2370506807 +1 From my side, I tested with a bundle and a flow. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] NIFI-13722: Kerberos ticket renewal issue due static thread pool in Iceberg library (nifi-1.x) [nifi]

2024-09-24 Thread via GitHub
mark-bathori commented on PR #9305: URL: https://github.com/apache/nifi/pull/9305#issuecomment-2370404507 Thanks @dan-s1 for the comments. This is a backport PR so these changes are already merged into the main branch. To keep the consistency between the two branch and PRs I would keep the

Re: [PR] NIFI-13796: When writing to a content claim and its size + offset exc… [nifi]

2024-09-23 Thread via GitHub
asfgit closed pull request #9306: NIFI-13796: When writing to a content claim and its size + offset exc… URL: https://github.com/apache/nifi/pull/9306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   3   4   5   6   7   8   9   10   >