[GitHub] nifi pull request #2968: NIFI-5456: AWS clients now work with private link e...

2018-12-12 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2968#discussion_r241044902 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-12 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r241005492 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,369

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240655171 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,291 @@ +nifi-cassandra

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240654783 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,369

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-12-05 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3105 @MikeThomsen I have worked on the LICENSE & NOTICE files as suggested. Please take a look now. ---

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-05 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r239164057 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi-cassandra

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-05 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r239163988 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi-cassandra

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-12-02 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3105 @MikeThomsen Yes, I am. ---

[GitHub] nifi issue #3190: NIFI-5850: Replaced custom AWS regions enum with the one f...

2018-12-01 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3190 > > > @zenfenan agree that bumping the version just before a release is a good idea (and we should try to do it for multiple bundles) but I still suggest to bump the version in t

[GitHub] nifi issue #3187: NIFI-5847 Added GovCloud-East region to enum list.

2018-11-29 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3187 @jmlogan It is an enum on the AWS SDK side so whatever new regions that are added to AWS cloud services, the team managing the SDK project update the enum on their side. ---

[GitHub] nifi pull request #3190: NIFI-5850: Replaced custom AWS regions enum with th...

2018-11-29 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/3190 NIFI-5850: Replaced custom AWS regions enum with the one from AWS Jav… …a SDK Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-21 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3167 @mattyb149 Fixed the checkstyle violation and rebased. ---

[GitHub] nifi issue #3135: [NIFI-5795] RedisDistributedMapCacheClientService put miss...

2018-11-21 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3135 @pvillard31 I wasn't able to. What do you suggest? We'll close this one and cover the objective with #3176 ? or we would merge this in once we verify the changes and ask @javajefe to re

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-18 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3167 Since there is some thought process required on how the primary node only restriction be effectively made on the `GenerateTableFetch`, I'll change this PR to only have the annotation o

[GitHub] nifi pull request #3011: NIFI-5333 Added GetMongoRecord.

2018-11-18 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3011#discussion_r234443725 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongoRecord.java --- @@ -0,0

[GitHub] nifi pull request #3167: NIFI-5812: Marked Database processors as 'PrimaryNo...

2018-11-12 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/3167 NIFI-5812: Marked Database processors as 'PrimaryNodeOnly' Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #3011: NIFI-5333 Added GetMongoRecord.

2018-11-09 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3011#discussion_r232223940 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml --- @@ -101,6 +101,7 @@ org.apache.nifi

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-10-30 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3105 @mattyb149 Rebased. ---

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-10-23 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3105 Note to reviewers: Please take a close look from the L&N perspective, especially the NOTICE file. I have basically re-used the NOTICE from the Cassandra processor bundle but I have few doubts w

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-10-23 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r227436737 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi-cassandra

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-10-23 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r227436607 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi-cassandra

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-10-23 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r227436263 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi-cassandra

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-10-23 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/3105 NIFI-5621: Added Cassandra connection provider service Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #3073: NIFI-5698: Fixed DeleteAzureBlobStorage bug

2018-10-15 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3073 > > > Confirmed that the reported issue happened before applying fix. And resolved with this fix. +1, merging. Thanks again @zenfenan! Sorry for introducing this ter

[GitHub] nifi pull request #3073: NIFI-5698: Fixed DeleteAzureBlobStorage bug

2018-10-14 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/3073 NIFI-5698: Fixed DeleteAzureBlobStorage bug Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #3011: NIFI-5333 Added GetMongoRecord.

2018-10-05 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3011 @MikeThomsen Will try to do by this weekend. ---

[GitHub] nifi issue #3025: NIFI-5605 Added UpdateCassandra.

2018-10-05 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3025 I think this can go in with `PutCassandraQL`. `PutCassandraRecord` actually performs inserts only. ---

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-19 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2896 +1 from me. Thanks for the contribution. Merged to the master. ---

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-17 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2992 I think we can merge this one, if everything checks out good instead of waiting. ---

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-17 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2992 Yeah, I have actually started the implementation for a connection pool service. Wasn't able to open up a Jira. Got held up with some other things. I'll be doing it and will also w

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-16 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r217948182 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-16 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r217948138 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-16 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r217947988 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-16 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r217945557 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBControllerService.java --- @@ -17,156

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-16 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r217945280 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBControllerService.java --- @@ -17,156

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-16 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r217945056 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBControllerService.java --- @@ -17,156

[GitHub] nifi issue #2993: NIFI-5333 Added GetMongoRecord.

2018-09-14 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2993 Will try to complete it by this weekend. Extremely sorry.. Got super busy for the past few days. ---

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-07 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2992 @MikeThomsen No complex setup is required. A Cassandra cluster has to be up and running. That's all. ---

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-05 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2992 NIFI-5510: Introducing PutCassandraRecord processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #2968: NIFI-5456: AWS clients now work with private link e...

2018-09-04 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2968#discussion_r215131280 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java

[GitHub] nifi issue #2968: NIFI-5456: AWS clients now work with private link endpoint...

2018-09-03 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2968 @Mermadi Had a chance to test it out? ---

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-03 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r214684778 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-03 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r214684734 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2958: NIFI-5544: GetMongo refactored

2018-08-30 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2958#discussion_r214022342 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -204,144

[GitHub] nifi pull request #2968: NIFI-5456: AWS clients now work with private link e...

2018-08-29 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2968#discussion_r213901647 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java

[GitHub] nifi pull request #2968: NIFI-5456: AWS clients now work with private link e...

2018-08-26 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2968 NIFI-5456: AWS clients now work with private link endpoints (VPC) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...

2018-08-21 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2946#discussion_r211700721 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java --- @@ -133,6 +133,7

[GitHub] nifi pull request #2958: NIFI-5544: GetMongo refactored

2018-08-21 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2958 NIFI-5544: GetMongo refactored Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...

2018-08-12 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2946#discussion_r209458600 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java --- @@ -182,6 +182,7

[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...

2018-08-12 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2946 NIFI-5494: Added ExpressionLanguage support to 'Hive Configuration Re… …sources' Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi pull request #2925: NIFI-5469 Additional italics and code formatting co...

2018-08-09 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2925#discussion_r209010726 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3256,9 +3361,9 @@ stream { image:s2s-rproxy-portnumber.svg["Port numb

[GitHub] nifi issue #2914: NIFI-5448 Added failure relationship to UpdateAttributes t...

2018-08-09 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2914 +1 Built it and verified the changes with a sample flow. Everything works as expected. Thanks @pvillard31 and @mcgilman for the reviews. Thanks @MikeThomsen. Merged to the master. ---

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-08 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2937 +1 Thanks @jtstorck. Merged to the master. Thanks @ottobackwards for reviewing. ---

[GitHub] nifi issue #2914: NIFI-5448 Added failure relationship to UpdateAttributes t...

2018-08-07 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2914 @MikeThomsen The suggestion made by @mcgilman sounds good to me. If we could rename `Stop Processing` to `Penalize`, that would make more sense. Thoughts? ---

[GitHub] nifi pull request #2925: NIFI-5469 Additional italics and code formatting co...

2018-08-07 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2925#discussion_r208232010 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3256,9 +3361,9 @@ stream { image:s2s-rproxy-portnumber.svg["Port numb

[GitHub] nifi pull request #2925: NIFI-5469 Additional italics and code formatting co...

2018-08-06 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2925#discussion_r207975946 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1486,35 +1588,35 @@ If no administrator action is taken, the configuration values

[GitHub] nifi pull request #2925: NIFI-5469 Additional italics and code formatting co...

2018-08-06 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2925#discussion_r207899982 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3256,9 +3361,9 @@ stream { image:s2s-rproxy-portnumber.svg["Port numb

[GitHub] nifi pull request #2924: NIFI-5450: Added ENDPOINT_OVERRIDE to AWS SQS proce...

2018-07-30 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2924 NIFI-5450: Added ENDPOINT_OVERRIDE to AWS SQS processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #2906: NIFI-5440 Added db and collection attributes to GetMongo o...

2018-07-26 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2906 Reviewing.. ---

[GitHub] nifi pull request #2881: NIFI-5413 Added additional documentation for PutMon...

2018-07-26 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2881#discussion_r205535512 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/resources/docs/org.apache.nifi.processors.mongodb.PutMongoRecord

[GitHub] nifi issue #2881: NIFI-5413 Added additional documentation for PutMongoRecor...

2018-07-26 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2881 Reviewing.. ---

[GitHub] nifi issue #2913: NIFI-5083: enabled EL support for processor configuration ...

2018-07-26 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2913 @snagafritz Hey.. I forgot to close this PR while merging. It is now merged to the master. Can you manually close this PR? ---

[GitHub] nifi issue #2913: NIFI-5083: enabled EL support for processor configuration ...

2018-07-26 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2913 +1 LGTM. Merged to master. Thanks @snagafritz ---

[GitHub] nifi issue #2913: NIFI-5083: enabled EL support for processor configuration ...

2018-07-26 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2913 Reviewing.. ---

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-07-24 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r204829727 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java --- @@ -0,0

[GitHub] nifi issue #2619: NIFI-5059 Updated MongoDBLookupService to be able to detec...

2018-07-01 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2619 @MikeThomsen I'm actually traveling with limited access to mails and internet. I'll try to take a look as soon as I can, if someone doesn't get to already. ---

[GitHub] nifi issue #2809: NIFI-5316 Fixed array handling for Avro that comes from Pa...

2018-06-28 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2809 Forgot to add the 'This closes #PR' in the commit message so it is still shown as open. :| ---

[GitHub] nifi issue #2809: NIFI-5316 Fixed array handling for Avro that comes from Pa...

2018-06-28 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2809 Thanks @bbende Merged to master ---

[GitHub] nifi pull request #2818: NIFI-5343: Fix GetMongo to properly read charset fr...

2018-06-27 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2818 NIFI-5343: Fix GetMongo to properly read charset from FlowFile attri… …butes Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-26 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2813 Sure @MikeThomsen I'll take a look ---

[GitHub] nifi pull request #2815: NIFI-5334: GetMongo keeps original attributes when ...

2018-06-26 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2815 NIFI-5334: GetMongo keeps original attributes when it has incoming co… …nnections Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of

[GitHub] nifi pull request #2808: NIFI-5332: Fix GetMongoIT test failures

2018-06-23 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2808 NIFI-5332: Fix GetMongoIT test failures Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-18 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r196073711 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-06-18 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2558 Thanks @ijokarumawak and @mattyb149 for the review. Thanks @pvillard31 Everything looks good. Merged to master. ---

[GitHub] nifi pull request #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-06-17 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2558#discussion_r195933469 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi issue #2751: NIFI-5221: Added 'Object Tagging' functionalities to S3 Pr...

2018-06-13 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2751 Actually after giving it some serious thought, the attribute approach does make more sense. Easy from the flow development perspective, and even when using ExecuteScript or a custom processor

[GitHub] nifi pull request #2751: NIFI-5221: Added 'Object Tagging' functionalities t...

2018-06-12 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2751#discussion_r194756360 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -205,11 +210,21

[GitHub] nifi pull request #2751: NIFI-5221: Added 'Object Tagging' functionalities t...

2018-06-12 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2751#discussion_r194751872 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -307,6 +328,20 @@ private

[GitHub] nifi pull request #2747: NIFI-5249 Dockerfile enhancements

2018-06-11 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2747#discussion_r194404103 --- Diff: nifi-docker/dockermaven/pom.xml --- @@ -44,7 +44,6 @@ apache

[GitHub] nifi pull request #2783: NIFI-5293 - add merge.uuid to MergeRecord processor

2018-06-11 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2783#discussion_r194399030 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeRecord.java --- @@ -89,6

[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...

2018-06-09 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2776#discussion_r194246883 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...

2018-06-09 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2776 NIFI-5284: Added JSON_TYPE support to RunMongoAggregation Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #2773: NIFI-5155: Add host address info to bulletins

2018-06-08 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2773 @mcgilman Are you saying regardless of the `setNodeAddress` API not setting anything, the cluster coordinator takes care of populating it ? ---

[GitHub] nifi pull request #2775: NIFI-5286: Updated FasterXML Jackson libraries to 2...

2018-06-08 Thread zenfenan
GitHub user zenfenan opened a pull request: https://github.com/apache/nifi/pull/2775 NIFI-5286: Updated FasterXML Jackson libraries to 2.9.5 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #2056: NIFI-4262 - MergeContent - option to add merged uuid in or...

2018-06-08 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2056 Pulled it and built it locally. Ran the template attached in [NIFI-4028](https://issues.apache.org/jira/browse/NIFI-4028) and verified it to be working as expected. Thanks @pvillard31 @markap14

[GitHub] nifi issue #2769: NIFI-5264 - Added attribute for validation error message i...

2018-06-08 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2769 Built it and tested locally. Tested with few runs and got the expected error messages in the attributes. Thanks @pvillard31 ---

[GitHub] nifi issue #2769: NIFI-5264 - Added attribute for validation error message i...

2018-06-08 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2769 Reviewing.. ---

[GitHub] nifi pull request #2751: NIFI-5221: Added 'Object Tagging' functionalities t...

2018-06-08 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2751#discussion_r194009838 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -205,11 +210,21

[GitHub] nifi pull request #2751: NIFI-5221: Added 'Object Tagging' functionalities t...

2018-06-08 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2751#discussion_r194009531 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -307,6 +328,20 @@ private

[GitHub] nifi issue #2773: NIFI-5155: Add host address info to bulletins

2018-06-07 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2773 I'm not entirely sure if this poses an immediate threat, but in the future when other extensions try to use the `getNodeAddress()` API, it might possibly be an issue, especially on the

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-07 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 @joewitt @MikeThomsen Thank you so much. I have merged it to the master +1 ---

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-07 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 @MikeThomsen We get compilation failure. Take a look at the travis logs. ---

[GitHub] nifi pull request #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven mod...

2018-06-06 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2765#discussion_r193611711 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-services-api/pom.xml --- @@ -45,6 +45,11 @@ com.github.stephenc.findbugs

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-06 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 Link to my Gist that has the full log: https://gist.github.com/zenfenan/2e260004ce3d27ded2312a2f36d8b300 ---

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-06 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 The snippet of the log that throws the error when the service is starting: ``` 2018-06-06 20:43:52,727 INFO [main] org.apache.nifi.web.server.JettyServer Loading WAR: E:\Workspace\ASF

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-06 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 Yes. I’m on windows. I built it with contrib-check. It built successfully but when I execute run-nifi.bat, I got errors thrown during when the GCP bundle gets loaded. I’m away from my

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-06 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 @joewitt @MikeThomsen Build is a success but when I run (i.e. execute nifi.sh/run-nifi.bat), it fails to bring up the service. That’s to do with the dependency issue in GCP bundle

[GitHub] nifi issue #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven module.

2018-06-06 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2765 Having it as static method sounds good to me. @MikeThomsen Have you looked into the dependency issue with the GCP bundle that I had raised earlier? On Wed, 6 Jun 2018 at 10:43 PM

[GitHub] nifi pull request #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven mod...

2018-06-06 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2765#discussion_r193427227 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/pom.xml --- @@ -80,6 +80,12 @@ json 1.8

[GitHub] nifi pull request #2765: NIFI-5271 Moved JSON_VALIDATOR to its own maven mod...

2018-06-06 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2765#discussion_r193425267 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/pom.xml --- @@ -80,6 +80,12 @@ json 1.8

  1   2   3   >