JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-844082215
Happy to contribute, thank you for the guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-840756785
@markap14 @markobean I just pushed a commit that I believe covers all
outstanding items.
--
This is an automated message from the Apache Git Service.
To respond to the
JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-839779931
> Thanks for the update @JonathanKessler . I do think that you addressed the
concerns that I had in the first review. Looked over it again. There are a few
places where
JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-832020685
@markap14 Pinging again, can you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-814925343
@markap14, just wanted to ping you to please take a second look when you
have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the
JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-795889476
I'm embarrassed by the flurry of commits today. I finally did a full build,
test and checkstyle like I'm supposed to prior to pushing this last checkstyle
fix. We should
JonathanKessler commented on pull request #4780:
URL: https://github.com/apache/nifi/pull/4780#issuecomment-795522377
@markap14 I just pushed a commit that I believe addresses everything. It was
a bit more involved than I anticipated so please let me know if I missed
anything.
