[GitHub] [nifi] NissimShiman commented on pull request #5878: NIFI-9814: Add Range Sampling strategy to SampleRecord

2022-08-03 Thread GitBox
NissimShiman commented on PR #5878: URL: https://github.com/apache/nifi/pull/5878#issuecomment-1204380413 Just noticed this was still open ... Follow commit looks good. Nice catch with additional @WriteAttributes of mime.count Verified that it is indeed added on flowfile output

[GitHub] [nifi] NissimShiman commented on pull request #5878: NIFI-9814: Add Range Sampling strategy to SampleRecord

2022-06-20 Thread GitBox
NissimShiman commented on PR #5878: URL: https://github.com/apache/nifi/pull/5878#issuecomment-1160641889 Very nice addition. I tested with various permutations (i.e. including an open start range, an open end range, leaving the value as a blank string and it behaved as designed.