[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-08-13 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-520945040 > Can you close this PR now that it has been split out? Okay --

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-07-31 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-517101715 @granthenke made changes suggestion on the main PR. #3611 ---

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-07-30 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-516671735 @granthenke I have split this PR into two. Kudu Put Operations: https://github.com/apache/nifi/pull/3610 Kudu

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-07-15 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-511491001 @granthenke Thanks for the second review, WIll make changes as suggested! ---

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-04-21 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-485284276 @granthenke Added All Kudu Supported Predicates for KuduScan Processor ---

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-04-15 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-483523178 @granthenke @markap14 thanks for the awesome feedback. made changes according to the suggestions. Please review ag

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-04-09 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-481429802 @markap14 1) I can certainly create an abstract or helper class to reuse of Kudu Client Connection. for

[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

2019-04-09 Thread GitBox
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-481369490 @granthenke that's a fantastic review, will update PR with suggested changes. @markap14 1) added Kud