[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-26 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-716745290 Yeah I like where you're headed with that. Are you thinking hashing across data sets would be the hashing implementation? Then we would have a separate detective wicked reco

[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-26 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-716726587 The cache key identifier could be used to identify the grouping of the data set and used as a key prefix. It sounds like it's just a matter of how we store record level hashes.

[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-25 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-716163041 It's been a while since we discussed this so I'm not familiar with the uuid strategy. if you are talking about the uuid on a flow file then that could be specified using the cac

[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-23 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-715482458 I'm sorry but I don't know what to use for the patch file. Total newb to git when it comes to these more advanced scenarios. --

[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-22 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-714820284 Last I remember getting the tests running but it was really hard to get the whole framework to build. It's super close. Please let me know if you need anything. I did add commit

[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-06-30 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-651851517 @MikeThomsen I tried following your steps for rebasing and I thought it all went ok but I seem to have a lot more commits now. Would you be able to advise? I'm not a git expert.