[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-05-21 Thread GitBox
alopresto commented on pull request #4289: URL: https://github.com/apache/nifi/pull/4289#issuecomment-632311149 @thenatog I believe this PR resolves the error you and I both got during testing of PR 4263 where if a secure cluster had multiple nodes running on the same physical/virtual serv

[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-05-21 Thread GitBox
alopresto commented on pull request #4289: URL: https://github.com/apache/nifi/pull/4289#issuecomment-632366081 I ran the GitHub Actions checks twice. The problem is with downloading a dependency for another module from a remote repository. Running the build on my local machine completes s

[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on pull request #4289: URL: https://github.com/apache/nifi/pull/4289#issuecomment-639223794 Thanks Mark. I replied to the comments and integrated most of what you had suggested (the exception being the complete removal of the marker interface). ---