apiri commented on a change in pull request #4156: NIFI-7273: Add flow metrics REST endpoint with for Prometheus scraping URL: https://github.com/apache/nifi/pull/4156#discussion_r398725206
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java ########## @@ -313,6 +313,11 @@ */ FlowConfigurationEntity getFlowConfiguration(); + /** + * Gets the metrics for the flow. + */ + void getFlowMetrics(); Review comment: minor: feels odd to call this a get when we don't return anything ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services