[GitHub] [nifi] dan-s1 commented on pull request #7634: NIFI-11873 Refactored PeerSelectorTest from Groovy to Java.

2023-08-21 Thread via GitHub
dan-s1 commented on PR #7634: URL: https://github.com/apache/nifi/pull/7634#issuecomment-1687082344 Should I close the ticket or just have the ticket no longer assigned to me? Also should I add you comments regarding the visibility issues to the ticket so others will know what to be aware o

[GitHub] [nifi] dan-s1 commented on pull request #7634: NIFI-11873 Refactored PeerSelectorTest from Groovy to Java.

2023-08-21 Thread via GitHub
dan-s1 commented on PR #7634: URL: https://github.com/apache/nifi/pull/7634#issuecomment-1687073953 I did not realize either. I worked off your original comment thinking it would be okay for the others. Aside from variables I am not sure how I would not reduce the scope of the methods whose

[GitHub] [nifi] dan-s1 commented on pull request #7634: NIFI-11873 Refactored PeerSelectorTest from Groovy to Java.

2023-08-21 Thread via GitHub
dan-s1 commented on PR #7634: URL: https://github.com/apache/nifi/pull/7634#issuecomment-1687048706 @exceptionfactory 21/22 of pass. There is one test testShouldFetchRemotePeerStatusesInFailureScenario which fails but the reasons vary each time its run. It appears it is due to some random