[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-25 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-767157976 Closing in favor of implementation in #4781 This is an automated message from the Apache Git Service. To r

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-25 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-767157976 Closing in favor of implementation in #4781 This is an automated message from the Apache Git Service. To r

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763865777 @adenes After evaluating the unit tests mentioned, I found that each one was performing date conversion in order to compare the expected results. The conversion changed t

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763806901 > @exceptionfactory , thanks for the follow-up commits. I ran the tests with CET system TZ and unfortunately some test cases fail: > > ``` > [ERROR] Failures:

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763605759 @markap14 Thanks for the review and additional feedback, I pushed an update to address your comments. There still appear to be some edge cases for some record-oriented pr

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-09 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-757089861 @turcsanyip The other use of `AvroTypeUtil.LOGICAL_TYPE_DATE` was in the `normalizeValue()`, which was causing the problem with `ConvertRecord`. The use of `new java.sql.

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-08 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-757089861 @turcsanyip The other use of `AvroTypeUtil.LOGICAL_TYPE_DATE` was in the `normalizeValue()`, which was causing the problem with `ConvertRecord`. The use of `new java.sql.

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-07 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-756137595 Thanks for the feedback and testing @turcsanyip. I will run some additional tests using the flow configuration described. ---

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-05 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-754765641 > @exceptionfactory , thanks for the PR. > > I ran the unit tests in CET timezone, and one of the newly added tests fails: > > ``` > [ERROR] testFormatted