[GitHub] [nifi] exceptionfactory commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2022-01-11 Thread GitBox
exceptionfactory commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1010309784 @timeabarna I rebased and add a new commit that refactors the sample filtering approach to use a logical OR when processing both the sampleName and sampleLabelValue param

[GitHub] [nifi] exceptionfactory commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2022-01-10 Thread GitBox
exceptionfactory commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1008945850 Thanks for the feedback @timeabarna! It sounds like matching against provided parameters should be a logical OR instead of a logical AND, which is how it is working at th

[GitHub] [nifi] exceptionfactory commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2022-01-06 Thread GitBox
exceptionfactory commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1006621448 @timeabarna Just following up on this thread, let me know what you think of the recent additional changes to filtering parameters, hopefully it covers the additional fiel

[GitHub] [nifi] exceptionfactory commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2021-12-18 Thread GitBox
exceptionfactory commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-997225825 @timeabarna I pushed an update with a refactored approach that supports filtering against the Sample Name and Sample Label Value fields using regular expression patterns.

[GitHub] [nifi] exceptionfactory commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2021-12-17 Thread GitBox
exceptionfactory commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-996751849 Thanks for following up on this @timeabarna, I will look at making the updates to this PR soon. -- This is an automated message from the Apache Git Service. To respond t