[GitHub] [nifi] exceptionfactory commented on pull request #5897: NIFI-9830: Use temp directory with post-rename during nar-unpacking

2022-04-27 Thread GitBox
exceptionfactory commented on PR #5897: URL: https://github.com/apache/nifi/pull/5897#issuecomment-146642 @gresockj In discussing this change with @markap14, it seems like a better approach would be the check for the presence of the digest file as an indicator of whether the unpacking

[GitHub] [nifi] exceptionfactory commented on pull request #5897: NIFI-9830: Use temp directory with post-rename during nar-unpacking

2022-04-06 Thread GitBox
exceptionfactory commented on PR #5897: URL: https://github.com/apache/nifi/pull/5897#issuecomment-1090673448 Thanks for the additional background @gresockj, that is helpful to know. Would it make more sense to check the contents of the working directory and unpack as needed? It seems

[GitHub] [nifi] exceptionfactory commented on pull request #5897: NIFI-9830: Use temp directory with post-rename during nar-unpacking

2022-04-06 Thread GitBox
exceptionfactory commented on PR #5897: URL: https://github.com/apache/nifi/pull/5897#issuecomment-1090575993 Thanks for the contribution @gresockj. Can you provide some additional details on how the change improves performance? It seems like there is more work involved in unpacking to a