[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-04 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1371264005 Thanks for adding the `Time Field` property @lizhizhou. To simplify the final stages of the review, can you squash all changes into a single commit? The current list of 27 com

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2023-01-02 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1369138557 @lizhizhou It looks like the latest updates included many historical commits, please rebase and force-push to correct the branch history. -- This is an automated message from the

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-30 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1368107974 It looks like the current build is failing due to differing parent POM versions. Recommend rebasing against the current main branch, which would be a good time to squash commits and

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-12-30 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1368106343 @lizhizhou I pushed a minor update to correct build errors related to removed CompressionType values, and also adjusted the unit test class name to match standard conventions. I wil

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-11-16 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1317747117 Thanks for the updates @lizhizhou, the record handling approach appears to be improved, I will take a closer look at this soon. -- This is an automated message from the Apache Git

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-10-24 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1289013596 Thanks for the recent updates @lizhizhou, I will take a closer look soon. At the moment, there is a merge conflict with `nifi-nar-bundles/pom.xml`, can you take a look and resolve?

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-10-18 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1282370452 Thank you for addressing the comments @lizhizhou. Can you remove the addition for the `QueryIoTDB` Processor? Although it also looks useful, it would be better to resolve and

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-10-14 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1279245278 Thanks for the reply, and for your work on this PR @xuanronaldo! When the final version is ready, we should be able to mention your contribution through a `Co-authored-by` line in t

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-10-05 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1265713692 I'm still planning on following up on this @xuanronaldo, but recent release efforts have taken precedence. Thanks for your patience. -- This is an automated message from the Apach

[GitHub] [nifi] exceptionfactory commented on pull request #6416: NIFI-10234 implement PutIoTDB

2022-09-19 Thread GitBox
exceptionfactory commented on PR #6416: URL: https://github.com/apache/nifi/pull/6416#issuecomment-1250957910 Thanks for the updated work @xuanronaldo, I should be able to take a closer look at the latest version soon. -- This is an automated message from the Apache Git Service. To respon