[GitHub] [nifi] jfrazee commented on pull request #4233: NIFI-7393: add max idle time and max idle connections parameter to InvokeHTTP

2020-06-04 Thread GitBox
jfrazee commented on pull request #4233: URL: https://github.com/apache/nifi/pull/4233#issuecomment-639056744 @Woutifier We'll be good to go after that little `name()` / `displayName()`. This is an automated message from the

[GitHub] [nifi] jfrazee commented on pull request #4233: NIFI-7393: add max idle time and max idle connections parameter to InvokeHTTP

2020-06-02 Thread GitBox
jfrazee commented on pull request #4233: URL: https://github.com/apache/nifi/pull/4233#issuecomment-637663394 @Woutifier I was able to test this by watching the stats given by the NGINX stub_status module. I can confirm that the Max Idle will cap the number of waiting connections to the ex

[GitHub] [nifi] jfrazee commented on pull request #4233: NIFI-7393: add max idle time and max idle connections parameter to InvokeHTTP

2020-05-21 Thread GitBox
jfrazee commented on pull request #4233: URL: https://github.com/apache/nifi/pull/4233#issuecomment-632336433 @Woutifier Other than my comment on validating that the time period is > 0 the code looks good. Is there an easy way to test this (not necessarily a unit test)? -