[GitHub] [nifi] joewitt commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…

2022-02-08 Thread GitBox
joewitt commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1033304869 On further thought... In this PR we do have an annotation to warn users. The EL examples provided where we're already inconsistent don't have that benefit. This is at leas

[GitHub] [nifi] joewitt commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…

2022-02-08 Thread GitBox
joewitt commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1033295071 I agree those are excellent examples of inconsistency and we should ensure we have disclaimers on them about usage. In a nifi 2.0 world I think we ought to punt those out for the

[GitHub] [nifi] joewitt commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…

2022-02-07 Thread GitBox
joewitt commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1031990263 So a summary of sorts: Improving validation of XML in content is good/great/useful and safe. Creating or increasing validation of XML in the context of attributes is far less des