markap14 commented on pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#issuecomment-844071657
Thanks @gresockj. I've seen no other reviews and no objections anywhere.
After putting it away for a few weeks I came back and did a thorough code
review myself as well. And the G
markap14 commented on pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#issuecomment-843476232
@gresockj thanks for all the review feedback! Now that I haven't looked at
my code in a while I did start refresh giving myself a full code review. I
think everything looked good
markap14 commented on pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#issuecomment-837226227
Rebased against main and addressed the issues that you found @gresockj.
Pushed a new commit.
--
This is an automated message from the Apache Git Service.
To respond to the mess
markap14 commented on pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#issuecomment-829469369
@joewitt agreed. Definitely need some good analysis of the changes here.
Good news is that the changes fall into 3 categories:
- Updating the API and StandardProcessSession. The
