[GitHub] [nifi] markap14 commented on pull request #7768: NIFI-12101: Fixed bugs that caused StatelessBasicsIT.testChangeFlowVe…

2023-09-22 Thread via GitHub
markap14 commented on PR #7768: URL: https://github.com/apache/nifi/pull/7768#issuecomment-1731620296 Thanks @exceptionfactory just realized that I didn't push that change. Will push another commit in one moment -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [nifi] markap14 commented on pull request #7768: NIFI-12101: Fixed bugs that caused StatelessBasicsIT.testChangeFlowVe…

2023-09-22 Thread via GitHub
markap14 commented on PR #7768: URL: https://github.com/apache/nifi/pull/7768#issuecomment-1731492439 Actually @exceptionfactory nevermind about the support branch - this fix does not need to go to the support branch, as it affects 2.0 only. The issue is in the StatelessBasicsIT, which test

[GitHub] [nifi] markap14 commented on pull request #7768: NIFI-12101: Fixed bugs that caused StatelessBasicsIT.testChangeFlowVe…

2023-09-22 Thread via GitHub
markap14 commented on PR #7768: URL: https://github.com/apache/nifi/pull/7768#issuecomment-1731484941 Yeah, sorry about that @exceptionfactory I did push without running through all of the system tests. I ran only the ones that I thought were affected, but I've updated the PR and ensured th

[GitHub] [nifi] markap14 commented on pull request #7768: NIFI-12101: Fixed bugs that caused StatelessBasicsIT.testChangeFlowVe…

2023-09-21 Thread via GitHub
markap14 commented on PR #7768: URL: https://github.com/apache/nifi/pull/7768#issuecomment-1729654543 Of note, in order to verify the fix, you can update the AbstractPort class such that the shutdown method sleeps before making the port as stopped: ``` @Override public void