markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1051183565
Thanks @markap14 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1051087898
The character set issue pointed out by @exceptionfactory refers to the
getBytes() call when reading an attribute value. Yet, @markap14 suggests using
the proposed character set
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1036460776
I am a -1 for an additional `ValidateXMLAttribute` processor. Such a
processor adds to processor bloat, and it does not solve any of the current
resistance outlined in this PR.
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1033290551
@markap14 I do not disagree with any points your have made about the dangers
of using large attributes. Also, thanks for detailing the reasons of why this
can be a problem for
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1031801195
Pinging once again. I think all discussions have been resolved and this is
ready to be merged. Are there any outstanding issues that I'm not seeing?
--
This is an automated
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1025168745
Still looking for a committer to wrap up this PR. There are no outstanding
change requests. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1014903291
Using ReplaceText goes against the purpose of this ticket. Already, the
content of a FlowFile can be validated. However, this ticket is to allow the
contents of an attribute to
markobean commented on pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#issuecomment-1009986427
The request to use `SafeXMLConfiguration` as been completed. I performed a
force-push because I rebased to current `main`. This seems to have prevented me
from marking the
