[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-09 Thread GitBox
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-756752576 @NissimShiman – good catch. That style text is used elsewhere in that way, so I'd say you're correct to apply here as well. Looks good to me; thanks for your work and attention to

[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-08 Thread GitBox
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-756752576 @NissimShiman – good catch. That style text is used elsewhere in that way, so I'd say you're correct to apply here as well. Looks good to me; thanks for your work and attention to

[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-05 Thread GitBox
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-754772546 @markap14 @NissimShiman I don’t think the tabular like appearance is necessary. Much like Start Date/Time, etc. these are just other fields upon which the user can search. I