mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-789382845
@markap14 I made revisions from your feedback. Thanks for looking at this in
detail!
This is an automated
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-789200993
@sardell Thanks for reviewing!
This is an automated message from the Apache Git Service.
To respond to the
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786974249
Just pushed a commit -
- Hide the Upload File button when grouping components @pvillard31
- Refactored `uploadProcessGroup` and exception handling @exceptionfactory
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786894887
@pvillard31 Agreed the upload file button should be removed when a user
clicks on the "Group" button. Will make the change.
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786770072
My last commit includes the disabled buttons, which completes this PR and is
ready for merge once it's approved. Thanks.
@pvillard31
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786767902
@exceptionfactory Thanks for reviewing! I've addressed your feedback and
committed the changes.
This is an
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786191291
@pvillard31 Good catch - I just pushed a commit that should fix this. If
uploading a flow that was downloaded from the canvas, the flow does not contain
snapshot metadata. I
mtien-apache commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786062176
@joewitt Yes! Changed the term to flow definition.
This is an automated message from the Apache Git Service.
