[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-16 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-614604897 Thanks @ijokarumawak! This is an automated message

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-613001810 Actually, having run check style with that enabled... it seems that it is more normal than I thought lol: ```bash

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612992109 Review and tests make sense, built with contrib-check all good. Personally, I don't think end of line comments are

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612984602 @ijokarumawak can you take a look, you have reviewed the wait processor stuff before

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612984447 Reviewing This is an automated message from the

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612880334 Thanks for improving this. Your diff's are the complete files. Please re-submit without formatting changes etc.