[GitHub] [nifi] ottobackwards commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…

2020-05-04 Thread GitBox
ottobackwards commented on pull request #4244: URL: https://github.com/apache/nifi/pull/4244#issuecomment-623598263 +1 fwiw pending ci-workflow completion This is an automated message from the Apache Git Service. To respond t

[GitHub] [nifi] ottobackwards commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…

2020-05-04 Thread GitBox
ottobackwards commented on pull request #4244: URL: https://github.com/apache/nifi/pull/4244#issuecomment-623572437 Great, the tests look like they are failing though This is an automated message from the Apache Git Service.

[GitHub] [nifi] ottobackwards commented on pull request #4244: NIFI-7414: Escape user-defined values that contain invalid XML charac…

2020-04-30 Thread GitBox
ottobackwards commented on pull request #4244: URL: https://github.com/apache/nifi/pull/4244#issuecomment-622066867 This looks right, though I'm not familiar with the code. Is there a way to write a test for this? This is a