[GitHub] [nifi] timeabarna commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2021-12-16 Thread GitBox
timeabarna commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-996473194 Thanks for the improvements @exceptionfactory! As discussed separately can you please incorporate the filtering with https://github.com/apache/nifi/pull/5582? Please let me know

[GitHub] [nifi] timeabarna commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2022-01-10 Thread GitBox
timeabarna commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1008811658 @exceptionfactory Unfortunately it is not working as expected for 5582. All the metrics required where sampleLabelValue is RootProcessGroup and all the jvm metrics. I am able t

[GitHub] [nifi] timeabarna commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2022-01-11 Thread GitBox
timeabarna commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1010713927 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [nifi] timeabarna commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

2022-01-11 Thread GitBox
timeabarna commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1010713799 Thanks @exceptionfactory for your help, looks good now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use