[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-22 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r734400026 ## File path: libminifi/src/core/Processor.cpp ## @@ -411,6 +410,17 @@ std::string Processor::getInputRequirementAsString() const { ret

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-21 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r733469790 ## File path: extensions/azure/processors/PutAzureBlobStorage.cpp ## @@ -242,10 +242,6 @@ void PutAzureBlobStorage::onTrigger(const std::s

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-19 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r731976987 ## File path: extensions/aws/processors/ListS3.h ## @@ -73,6 +73,10 @@ class ListS3 : public S3Processor { return core::annotation::In

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-19 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r731961909 ## File path: libminifi/include/core/Processor.h ## @@ -144,13 +144,14 @@ class Processor : public Connectable, public ConfigurableCompone

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-07 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r724006315 ## File path: libminifi/src/core/Processor.cpp ## @@ -379,25 +379,37 @@ std::shared_ptr Processor::pickIncomingConnection() { return ge

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-07 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r724090579 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -432,6 +439,7 @@ void ConsumeWindowsEventLog::onTrigger(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-07 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r724090421 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -388,6 +389,12 @@ void ConsumeWindowsEventLog::onTrigger(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-07 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r724006315 ## File path: libminifi/src/core/Processor.cpp ## @@ -379,25 +379,37 @@ std::shared_ptr Processor::pickIncomingConnection() { return ge

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-06 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r723384271 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -188,7 +188,6 @@ ConsumeWindowsEventLog::ConsumeWindowsEventLog

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-05 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r722252824 ## File path: extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp ## @@ -435,7 +435,6 @@ bool SourceInitiatedSubscrip

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-05 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r722004477 ## File path: libminifi/src/core/Processor.cpp ## @@ -385,17 +385,20 @@ void Processor::validateAnnotations() const { if (!hasIncomi

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

2021-10-05 Thread GitBox
adam-markovics commented on a change in pull request #1191: URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r722004477 ## File path: libminifi/src/core/Processor.cpp ## @@ -385,17 +385,20 @@ void Processor::validateAnnotations() const { if (!hasIncomi