[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816467499 ## File path: libminifi/src/core/yaml/YamlConfiguration.cpp ## @@ -697,10 +689,21 @@ PropertyValue YamlConfiguration::getValidatedProcesso

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816487780 ## File path: libminifi/include/processors/ProcessorUtils.h ## @@ -47,10 +45,10 @@ class ProcessorUtils { if (ptr == nullptr) {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816467679 ## File path: libminifi/src/core/yaml/YamlConfiguration.cpp ## @@ -697,10 +689,21 @@ PropertyValue YamlConfiguration::getValidatedProcesso

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816099474 ## File path: extensions/standard-processors/processors/GetTCP.h ## @@ -269,10 +268,10 @@ class GetTCP : public core::Processor, public st

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816095354 ## File path: libminifi/include/core/ProcessGroup.h ## @@ -176,29 +170,27 @@ class ProcessGroup : public CoreComponent { parent_proces

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816095090 ## File path: libminifi/include/core/ProcessGroup.h ## @@ -207,11 +199,18 @@ class ProcessGroup : public CoreComponent { return nullpt

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816094976 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -91,33 +91,17 @@ ProcessGroup::~ProcessGroup() { } } -bool ProcessGroup::isRo

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816094819 ## File path: libminifi/include/core/state/nodes/QueueMetrics.h ## @@ -57,16 +57,16 @@ class QueueMetrics : public ResponseNode { retu

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816094286 ## File path: extensions/test-processors/LogOnDestructionProcessor.h ## @@ -0,0 +1,43 @@ +/** + * + * Licensed to the Apache Software Found

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816094190 ## File path: extensions/test-processors/LogOnDestructionProcessor.h ## @@ -0,0 +1,43 @@ +/** + * + * Licensed to the Apache Software Found

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816093694 ## File path: docker/test/integration/minifi/core/TransientMinifiContainer.py ## @@ -0,0 +1,8 @@ +from .MinifiContainer import MinifiContai

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816093101 ## File path: extensions/rocksdb-repos/FlowFileRepository.h ## @@ -75,24 +75,28 @@ class FlowFileRepository : public core::Repository, publ

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816091151 ## File path: extensions/http-curl/tests/C2ClearCoreComponentStateTest.cpp ## @@ -50,10 +50,10 @@ class VerifyC2ClearCoreComponentState : p

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816090304 ## File path: docker/test/integration/minifi/core/TransientMinifiContainer.py ## @@ -0,0 +1,8 @@ +from .MinifiContainer import MinifiContai

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r815994765 ## File path: libminifi/src/core/yaml/YamlConfiguration.cpp ## @@ -697,10 +689,21 @@ PropertyValue YamlConfiguration::getValidatedProcesso

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r815991953 ## File path: libminifi/include/core/repository/VolatileRepository.h ## @@ -203,6 +195,8 @@ VolatileRepository::~VolatileRepository() {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r815987444 ## File path: extensions/standard-processors/processors/GetTCP.h ## @@ -269,10 +268,10 @@ class GetTCP : public core::Processor, public st

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r815979616 ## File path: extensions/rocksdb-repos/FlowFileRepository.h ## @@ -75,24 +75,28 @@ class FlowFileRepository : public core::Repository, publ

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813119543 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -91,33 +91,16 @@ ProcessGroup::~ProcessGroup() { } } -bool ProcessGroup::isRo

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813096443 ## File path: libminifi/include/FlowController.h ## @@ -87,13 +91,8 @@ class FlowController : public core::controller::ForwardingControlle

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813081971 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -91,33 +91,16 @@ ProcessGroup::~ProcessGroup() { } } -bool ProcessGroup::isRo

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813076778 ## File path: libminifi/src/FlowController.cpp ## @@ -271,7 +271,7 @@ std::unique_ptr FlowController::loadInitialFlow() { return root;

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813076252 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -1034,14 +1030,18 @@ void ProcessSession::ensureNonNullResourceClaim( } std::

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813073651 ## File path: libminifi/src/core/Connectable.cpp ## @@ -141,39 +141,37 @@ void Connectable::notifyWork() { } } -std::set> Connectabl

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813063557 ## File path: libminifi/src/c2/C2Client.cpp ## @@ -115,7 +116,8 @@ void C2Client::initialize(core::controller::ControllerServiceProvider *

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813057050 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -34,6 +34,16 @@ constexpr T intdiv_ceil(T numerator, T denominator) { : n

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813054984 ## File path: libminifi/include/processors/ProcessorUtils.h ## @@ -61,25 +59,15 @@ class ProcessorUtils { if (ptr == nullptr) {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r812943881 ## File path: libminifi/include/processors/ProcessorUtils.h ## @@ -47,10 +45,10 @@ class ProcessorUtils { if (ptr == nullptr) {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r812927444 ## File path: libminifi/include/core/state/nodes/QueueMetrics.h ## @@ -57,16 +57,16 @@ class QueueMetrics : public ResponseNode { retu

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r812918357 ## File path: libminifi/include/FlowController.h ## @@ -87,13 +91,8 @@ class FlowController : public core::controller::ForwardingControlle

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r807642361 ## File path: CMakeLists.txt ## @@ -611,6 +612,11 @@ if (ENABLE_KUBERNETES) createExtension(KUBERNETES-EXTENSIONS "KUBERNETES EXTENSIONS

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806957651 ## File path: extensions/aws/processors/ListS3.h ## @@ -33,6 +33,7 @@ namespace org { namespace apache { namespace nifi { namespace mini

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806966150 ## File path: CMakeLists.txt ## @@ -611,6 +612,11 @@ if (ENABLE_KUBERNETES) createExtension(KUBERNETES-EXTENSIONS "KUBERNETES EXTENSIONS

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806957651 ## File path: extensions/aws/processors/ListS3.h ## @@ -33,6 +33,7 @@ namespace org { namespace apache { namespace nifi { namespace mini

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r801361215 ## File path: docker/DockerVerify.sh ## @@ -74,4 +74,5 @@ BEHAVE_OPTS=(-f pretty --logging-level INFO --logging-clear-handlers) # behave

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799399664 ## File path: docker/test/integration/minifi/core/SingleNodeDockerCluster.py ## @@ -68,6 +68,12 @@ def acquire_container(self, name, engine

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799304143 ## File path: extensions/windows-event-log/tests/BookmarkTests.cpp ## @@ -38,8 +38,8 @@ constexpr DWORD EVT_NEXT_TIMEOUT_MS = 100; std::

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799292146 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -34,6 +34,16 @@ constexpr T intdiv_ceil(T numerator, T denominator) { : n

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799262392 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -34,6 +34,16 @@ constexpr T intdiv_ceil(T numerator, T denominator) { : n

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799254191 ## File path: libminifi/include/core/state/nodes/QueueMetrics.h ## @@ -57,16 +57,16 @@ class QueueMetrics : public ResponseNode { retu

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799253747 ## File path: libminifi/include/core/Repository.h ## @@ -118,12 +118,12 @@ class Repository : public virtual core::SerializableComponent,

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799252395 ## File path: docker/test/integration/features/core_functionality.feature ## @@ -29,3 +29,10 @@ Feature: Core flow functionalities Whe

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798560554 ## File path: extensions/http-curl/tests/ControllerServiceIntegrationTests.cpp ## @@ -82,9 +82,10 @@ int main(int argc, char **argv) {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798559536 ## File path: extensions/http-curl/tests/C2NullConfiguration.cpp ## @@ -61,10 +61,10 @@ class VerifyC2Server : public HTTPIntegrationBase {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798555769 ## File path: controller/Controller.h ## @@ -246,18 +246,18 @@ std::shared_ptr configuration->get(org::apache::nifi::minifi::Configu

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798547237 ## File path: extensions/aws/processors/ListS3.h ## @@ -33,6 +33,11 @@ namespace org { namespace apache { namespace nifi { namespace min

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798543126 ## File path: extensions/aws/processors/PutS3Object.h ## @@ -30,6 +30,7 @@ #include #include +#include "io/StreamPipe.h" Review comm

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798542750 ## File path: extensions/aws/processors/FetchS3Object.h ## @@ -27,6 +27,7 @@ #include #include +#include "io/StreamPipe.h" Review co

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798542026 ## File path: controller/Controller.h ## @@ -246,18 +246,18 @@ std::shared_ptr configuration->get(org::apache::nifi::minifi::Configu