adam-markovics commented on PR #1381:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1381#issuecomment-1208105383
This pull request doesn't make ListenHTTPTests run slower. On main it is the
same time (1 minute 45 seconds) as with this PR, measured in release.
In debug, main fails
adam-markovics commented on PR #1381:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1381#issuecomment-1207803345
> While this makes the test green, ListenHTTPTests are also running awfully
long now, for almost 2 minutes, regularly. Could you have a look into why is
this the case? It
adam-markovics commented on PR #1381:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1381#issuecomment-1206203563
> Not strictly related, but there is a Clang Tidy check failure in
`ListenHTTPTests.cpp`, line 183:
>
> ```
>
adam-markovics commented on PR #1381:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1381#issuecomment-1205564837
CivetWeb's default implementations for request handlers (including PUT and
DELETE) return error codes, indicating they didn't handle the request
(returning `false`). Then
