[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603295791 ## File path: extensions/http-curl/tests/C2VerifyResourceConsumptionInHeartbeat.cpp ## @@ -0,0 +1,133 @@ +/** Review comment: we wil

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603132719 ## File path: libminifi/include/core/state/Value.h ## @@ -228,36 +225,36 @@ class IntValue : public Value { } protected: - virtual b

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603098402 ## File path: libminifi/include/core/state/Value.h ## @@ -228,36 +225,36 @@ class IntValue : public Value { } protected: - virtual b

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603069419 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -427,13 +427,15 @@ class AgentStatus : public StateMonitorNode {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603068827 ## File path: libminifi/include/core/state/Value.h ## @@ -580,6 +573,10 @@ struct SerializedResponseNode { SerializedResponseNode(const S

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600354264 ## File path: libminifi/include/core/state/Value.h ## @@ -380,9 +411,59 @@ class Int64Value : public Value { return false; } + vi

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600418932 ## File path: libminifi/test/unit/ResponseNodeValueTests.cpp ## @@ -0,0 +1,113 @@ +/** + * + * Licensed to the Apache Software Foundation (A

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600410229 ## File path: libminifi/src/utils/SystemCPUUsageTracker.cpp ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformat

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformat

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformat

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformat

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformat

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformat

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600387294 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -197,10 +200,117 @@ uint64_t OsUtils::getMemoryUsage() { throw std::runtime_error("

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600369706 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -425,77 +427,121 @@ class AgentStatus : public StateMonitorNode {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600363533 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -425,77 +427,121 @@ class AgentStatus : public StateMonitorNode {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600354264 ## File path: libminifi/include/core/state/Value.h ## @@ -380,9 +411,59 @@ class Int64Value : public Value { return false; } + vi

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600354264 ## File path: libminifi/include/core/state/Value.h ## @@ -380,9 +411,59 @@ class Int64Value : public Value { return false; } + vi