[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615710315 ## File path: extensions/standard-processors/tests/unit/YamlProcessGroupParserTests.cpp ## @@ -0,0 +1,130 @@ +/** + * Licensed to the Apach

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615709266 ## File path: extensions/standard-processors/tests/unit/ProcessGroupTestUtils.h ## @@ -0,0 +1,288 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615642485 ## File path: libminifi/src/core/yaml/YamlConfiguration.cpp ## @@ -49,35 +49,45 @@ YamlConfiguration::YamlConfiguration(const std::shared_p

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615642084 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -255,21 +245,21 @@ void ProcessGroup::stopProcessing(const std::shared_ptr ProcessG

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615642084 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -255,21 +245,21 @@ void ProcessGroup::stopProcessing(const std::shared_ptr ProcessG

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615640996 ## File path: libminifi/include/core/ProcessGroup.h ## @@ -57,7 +60,12 @@ enum ProcessGroupType { // ProcessGroup Class class ProcessGro

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1045: MINIFICPP-1535 - Support process groups

2021-04-19 Thread GitBox
adamdebreceni commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r615640698 ## File path: libminifi/include/core/FlowConfiguration.h ## @@ -106,6 +106,7 @@ class FlowConfiguration : public CoreComponent { // Creat