[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450097829 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450097829 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450097829 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450073786 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450073786 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-05 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450014693 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-05 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450014693 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-05 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450014693 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-05 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r450014693 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-01 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r448156824 ## File path: libminifi/test/flow-tests/FlowControllerTests.cpp ## @@ -0,0 +1,125 @@ +/** + * + * Licensed to the Apache Software Foundation (

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-07-01 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r448156824 ## File path: libminifi/test/flow-tests/FlowControllerTests.cpp ## @@ -0,0 +1,125 @@ +/** + * + * Licensed to the Apache Software Foundation (

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-06-30 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r448154480 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -92,13 +92,12 @@ ProcessGroup::~ProcessGroup() { onScheduleTimer_->stop(); }

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-06-30 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r447575841 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #827: MINIFICPP-1273 - Drain connections on flow shutdown

2020-06-30 Thread GitBox
adamdebreceni commented on a change in pull request #827: URL: https://github.com/apache/nifi-minifi-cpp/pull/827#discussion_r447574816 ## File path: libminifi/test/flow-tests/CMakeLists.txt ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#