[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #938: MINIFICPP-1408 thrown objects should be derived from std::exception

2020-11-18 Thread GitBox
adamdebreceni commented on a change in pull request #938: URL: https://github.com/apache/nifi-minifi-cpp/pull/938#discussion_r525899629 ## File path: extensions/sftp/client/SFTPClient.h ## @@ -49,6 +50,12 @@ enum class SFTPError : uint8_t { SFTP_ERROR_UNEXPECTED }; +struc

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #938: MINIFICPP-1408 thrown objects should be derived from std::exception

2020-11-18 Thread GitBox
adamdebreceni commented on a change in pull request #938: URL: https://github.com/apache/nifi-minifi-cpp/pull/938#discussion_r525899629 ## File path: extensions/sftp/client/SFTPClient.h ## @@ -49,6 +50,12 @@ enum class SFTPError : uint8_t { SFTP_ERROR_UNEXPECTED }; +struc

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #938: MINIFICPP-1408 thrown objects should be derived from std::exception

2020-11-17 Thread GitBox
adamdebreceni commented on a change in pull request #938: URL: https://github.com/apache/nifi-minifi-cpp/pull/938#discussion_r525108234 ## File path: extensions/sftp/client/SFTPClient.h ## @@ -49,6 +50,12 @@ enum class SFTPError : uint8_t { SFTP_ERROR_UNEXPECTED }; +struc

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #938: MINIFICPP-1408 thrown objects should be derived from std::exception

2020-11-17 Thread GitBox
adamdebreceni commented on a change in pull request #938: URL: https://github.com/apache/nifi-minifi-cpp/pull/938#discussion_r525108396 ## File path: extensions/sftp/client/SFTPClient.h ## @@ -49,6 +50,12 @@ enum class SFTPError : uint8_t { SFTP_ERROR_UNEXPECTED }; +struc