[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-07 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r537355725 ## File path: libminifi/include/utils/tls/CertificateUtils.h ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535929166 ## File path: libminifi/src/utils/tls/DistinguishedName.cpp ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535926302 ## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535926302 ## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535908118 ## File path: libminifi/include/utils/tls/WindowsCertStoreLocation.h ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-03 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535328333 ## File path: libminifi/src/controllers/SSLContextService.cpp ## @@ -269,10 +505,8 @@ void SSLContextService::onEnable() { } passphr

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-03 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535295187 ## File path: libminifi/include/utils/tls/CertificateUtils.h ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-03 Thread GitBox
adamdebreceni commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535295187 ## File path: libminifi/include/utils/tls/CertificateUtils.h ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und