arpadboda commented on issue #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#issuecomment-583156912 Nice catch! Please fix the linter errors: ``` /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//io/win/ClientSocket.cpp:41: Do not indent within a namespace [runtime/indentation_namespace] [4] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//io/win/ClientSocket.cpp:46: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] ``` Otherwise I'm happy with this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
