[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r465978905 ## File path: libminifi/include/io/CRCStream.h ## @@ -224,7 +222,7 @@ template int CRCStream::readData(uint8_t *buf, int buflen) { int ret =

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r465979548 ## File path: extensions/http-curl/processors/InvokeHTTP.cpp ## @@ -337,7 +337,7 @@ void InvokeHTTP::onTrigger(const std::shared_ptr , const

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r465979206 ## File path: libminifi/src/sitetosite/SiteToSiteClient.cpp ## @@ -499,8 +499,9 @@ int16_t SiteToSiteClient::send(std::string transactionID,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r465978905 ## File path: libminifi/include/io/CRCStream.h ## @@ -224,7 +222,7 @@ template int CRCStream::readData(uint8_t *buf, int buflen) { int ret =

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r465977037 ## File path: nanofi/src/core/cstream.c ## @@ -153,9 +148,9 @@ int readUTFLen(uint32_t * utflen, cstream * stream) { return ret; } -int

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463113874 ## File path: extensions/libarchive/BinFiles.h ## @@ -91,7 +92,7 @@ class Bin { if (flow->getAttribute(fileCount_, value)) { try {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463111602 ## File path: libminifi/include/io/Serializable.h ## @@ -44,8 +44,9 @@ Integral byteSwap(Integral i) { #ifdef htonll return htonll(i); #else

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #848: MINIFICPP-1268 Fix compiler warnings on Windows (VS2017)

fgerlits commented on a change in pull request #848: URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463111602 ## File path: libminifi/include/io/Serializable.h ## @@ -44,8 +44,9 @@ Integral byteSwap(Integral i) { #ifdef htonll return htonll(i); #else