[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-08 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538641311 ## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-08 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538631795 ## File path: libminifi/src/controllers/SSLContextService.cpp ## @@ -128,16 +149,239 @@ bool SSLContextService::configure_ssl_context(SSL_CTX

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-08 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538629206 ## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-08 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538627427 ## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-07 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r537626531 ## File path: libminifi/src/controllers/SSLContextService.cpp ## @@ -128,16 +149,234 @@ bool SSLContextService::configure_ssl_context(SSL_CTX

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-07 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r537367796 ## File path: libminifi/include/utils/tls/CertificateUtils.h ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-07 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r537345098 ## File path: libminifi/include/utils/tls/CertificateUtils.h ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535969312 ## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535968353 ## File path: libminifi/include/utils/tls/WindowsCertStoreLocation.h ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535968353 ## File path: libminifi/include/utils/tls/WindowsCertStoreLocation.h ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535967134 ## File path: libminifi/src/utils/tls/DistinguishedName.cpp ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-04 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535961701 ## File path: libminifi/src/utils/tls/DistinguishedName.cpp ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-03 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535467558 ## File path: libminifi/include/utils/tls/CertificateUtils.h ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-03 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535466913 ## File path: libminifi/src/controllers/SSLContextService.cpp ## @@ -269,10 +505,8 @@ void SSLContextService::onEnable() { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

2020-12-03 Thread GitBox
fgerlits commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535196611 ## File path: libminifi/src/utils/tls/WindowsCertStoreLocation.cpp ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF)