[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1451: MINIFICPP-1962 Implement communication between process groups through ports

2022-11-24 Thread GitBox
fgerlits commented on code in PR #1451: URL: https://github.com/apache/nifi-minifi-cpp/pull/1451#discussion_r1031580822 ## libminifi/include/core/ProcessGroup.h: ## @@ -164,18 +166,23 @@ class ProcessGroup : public CoreComponent { std::lock_guard lock(mutex_); return p

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1451: MINIFICPP-1962 Implement communication between process groups through ports

2022-11-24 Thread GitBox
fgerlits commented on code in PR #1451: URL: https://github.com/apache/nifi-minifi-cpp/pull/1451#discussion_r1031578662 ## libminifi/src/core/yaml/YamlConfiguration.cpp: ## @@ -771,14 +777,44 @@ void YamlConfiguration::parseFunnelsYaml(const YAML::Node& node, core::ProcessGr

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1451: MINIFICPP-1962 Implement communication between process groups through ports

2022-11-24 Thread GitBox
fgerlits commented on code in PR #1451: URL: https://github.com/apache/nifi-minifi-cpp/pull/1451#discussion_r1031576978 ## libminifi/src/core/ProcessGroup.cpp: ## @@ -101,6 +101,15 @@ void ProcessGroup::addProcessor(std::unique_ptr processor) { } else { logger_->log_deb

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1451: MINIFICPP-1962 Implement communication between process groups through ports

2022-11-22 Thread GitBox
fgerlits commented on code in PR #1451: URL: https://github.com/apache/nifi-minifi-cpp/pull/1451#discussion_r1029308681 ## libminifi/include/core/ProcessGroup.h: ## @@ -164,18 +166,23 @@ class ProcessGroup : public CoreComponent { std::lock_guard lock(mutex_); return p