[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1592: MINIFICPP-2131 Refactored GetTCP

2023-06-30 Thread via GitHub
fgerlits commented on code in PR #1592: URL: https://github.com/apache/nifi-minifi-cpp/pull/1592#discussion_r1247960613 ## extensions/standard-processors/processors/GetTCP.cpp: ## @@ -17,275 +17,287 @@ */ #include "GetTCP.h" -#ifndef WIN32 -#include -#endif #include -#in

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1592: MINIFICPP-2131 Refactored GetTCP

2023-06-29 Thread via GitHub
fgerlits commented on code in PR #1592: URL: https://github.com/apache/nifi-minifi-cpp/pull/1592#discussion_r1243980137 ## extensions/standard-processors/processors/TailFile.cpp: ## @@ -343,10 +331,11 @@ void TailFile::onSchedule(const std::shared_ptr &context, throw Excep