[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

hunyadi-dev commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r615653769 ## File path: extensions/standard-processors/processors/HashContent.cpp ## @@ -84,6 +82,7 @@ void HashContent::onTrigger(core::ProcessContext

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

hunyadi-dev commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r607787916 ## File path: libminifi/src/c2/ControllerSocketProtocol.cpp ## @@ -51,18 +49,13 @@ void ControllerSocketProtocol::initialize(core::controller

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

hunyadi-dev commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r607787916 ## File path: libminifi/src/c2/ControllerSocketProtocol.cpp ## @@ -51,18 +49,13 @@ void ControllerSocketProtocol::initialize(core::controller

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

hunyadi-dev commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r607783909 ## File path: extensions/standard-processors/processors/HashContent.cpp ## @@ -84,6 +82,7 @@ void HashContent::onTrigger(core::ProcessContext

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

hunyadi-dev commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r607779530 ## File path: extensions/standard-processors/processors/GetTCP.cpp ## @@ -130,7 +130,7 @@ void GetTCP::onSchedule(const std::shared_ptr &cont

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

hunyadi-dev commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r607752496 ## File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp ## @@ -146,7 +148,7 @@ void AbstractMQTTProcessor::onSchedule(const std::s