[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r592302026 ## File path: extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp ## @@ -563,7 +563,7 @@ bool SourceInitiatedSubscriptionL

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r592212196 ## File path: nanofi/src/api/nanofi.cpp ## @@ -457,7 +457,7 @@ int get_content(const flow_file_record* ff, uint8_t* target, int size) { re

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r591709988 ## File path: nanofi/src/api/nanofi.cpp ## @@ -457,7 +457,7 @@ int get_content(const flow_file_record* ff, uint8_t* target, int size) { re

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r591709350 ## File path: bstrp_functions.sh ## @@ -375,6 +376,7 @@ show_supported_features() { echo "4. Use Shared Dependency Links .$(print_feature_sta

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585621406 ## File path: extensions/standard-processors/processors/GenerateFlowFile.cpp ## @@ -87,7 +87,7 @@ void generateData(std::vector& data, bool text

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585620832 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -305,8 +305,10 @@ bool StringUtils::from_base64(uint8_t* data, size_t* data_length, con

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585618681 ## File path: nanofi/examples/monitor_directory.c ## @@ -75,11 +77,11 @@ int main(int argc, char **argv) { port.port_id = portStr; - C2_

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585618228 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -74,8 +74,8 @@ static void setHostName(struct SiteToSiteCPeer * peer, const char * hostna

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585534552 ## File path: nanofi/include/sitetosite/CRawSocketProtocol.h ## @@ -76,23 +76,15 @@ int16_t sendPacket(struct CRawSiteToSiteClient * client, co

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585491374 ## File path: extensions/standard-processors/processors/GenerateFlowFile.cpp ## @@ -87,7 +87,7 @@ void generateData(std::vector& data, bool text

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585417128 ## File path: extensions/coap/nanofi/coap_functions.c ## @@ -115,6 +121,7 @@ int create_endpoint_context(coap_context_t **ctx, const char *node