[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution

2022-01-21 Thread GitBox
lordgamez commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789586909 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -211,7 +211,7 @@ void ConsumeKafka::onSchedule(core::ProcessContext* context,

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution

2022-01-21 Thread GitBox
lordgamez commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r789553463 ## File path: extensions/script/ExecuteScript.cpp ## @@ -123,6 +128,10 @@ void ExecuteScript::onTrigger(const std::shared_ptr throw

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution

2022-01-12 Thread GitBox
lordgamez commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r783217800 ## File path: extensions/script/ScriptEngine.h ## @@ -41,7 +43,14 @@ class ScriptEngine { */ virtual void evalFile(const std::string

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution

2022-01-12 Thread GitBox
lordgamez commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r783217800 ## File path: extensions/script/ScriptEngine.h ## @@ -41,7 +43,14 @@ class ScriptEngine { */ virtual void evalFile(const std::string

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1237: MINIFICPP-1224 Add module directory support to script execution

2022-01-12 Thread GitBox
lordgamez commented on a change in pull request #1237: URL: https://github.com/apache/nifi-minifi-cpp/pull/1237#discussion_r783212100 ## File path: extensions/script/lua/LuaScriptEngine.cpp ## @@ -65,15 +65,32 @@ LuaScriptEngine::LuaScriptEngine() void