[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-08 Thread GitBox
lordgamez commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r801353913 ## File path: docker/DockerVerify.sh ## @@ -74,4 +74,5 @@ BEHAVE_OPTS=(-f pretty --logging-level INFO --logging-clear-handlers) # behave

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-04 Thread GitBox
lordgamez commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799307691 ## File path: extensions/windows-event-log/tests/BookmarkTests.cpp ## @@ -38,8 +38,8 @@ constexpr DWORD EVT_NEXT_TIMEOUT_MS = 100;

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-04 Thread GitBox
lordgamez commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799264974 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -34,6 +34,16 @@ constexpr T intdiv_ceil(T numerator, T denominator) { :

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-04 Thread GitBox
lordgamez commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r799246960 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -34,6 +34,16 @@ constexpr T intdiv_ceil(T numerator, T denominator) { :

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-03 Thread GitBox
lordgamez commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798685117 ## File path: docker/test/integration/features/core_functionality.feature ## @@ -29,3 +29,10 @@ Feature: Core flow functionalities When