[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r489387584 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -298,120 +298,111 @@ void ConsumeWindowsEventLog::onSchedule(const st

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r484783867 ## File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp ## @@ -367,27 +372,19 @@ void batchCommitSizeTestHelper(int batch

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r484783119 ## File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp ## @@ -367,27 +372,19 @@ void batchCommitSizeTestHelper(int batch

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r484782831 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -298,120 +298,108 @@ void ConsumeWindowsEventLog::onSchedule(const st

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r484781905 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -298,120 +298,108 @@ void ConsumeWindowsEventLog::onSchedule(const st

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r484781607 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -298,120 +298,108 @@ void ConsumeWindowsEventLog::onSchedule(const st

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r482990129 ## File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp ## @@ -335,21 +335,26 @@ TEST_CASE("ConsumeWindowsEventLog prints

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #891: MINIFICPP-1349 ConsumeWindowsEventLogs should honor batch commit size in a single session

lordgamez commented on a change in pull request #891: URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r482990129 ## File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp ## @@ -335,21 +335,26 @@ TEST_CASE("ConsumeWindowsEventLog prints