lordgamez commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165592135
##
extensions/aws/CMakeLists.txt:
##
@@ -34,6 +34,9 @@ add_library(minifi-aws SHARED ${SOURCES})
target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI} Threads
lordgamez commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165592135
##
extensions/aws/CMakeLists.txt:
##
@@ -34,6 +34,9 @@ add_library(minifi-aws SHARED ${SOURCES})
target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI} Threads
lordgamez commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165209315
##
extensions/aws/CMakeLists.txt:
##
Review Comment:
Restricted linkage and removed test workaround in
3ad1d51a4b678eed4550251c33f5a0a62d19d524
--
T
lordgamez commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1164391311
##
extensions/aws/CMakeLists.txt:
##
Review Comment:
It seems that I was wrong as the linkage problem didn't originate from the
aws crt library as I ori
lordgamez commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1164391311
##
extensions/aws/CMakeLists.txt:
##
Review Comment:
It seems that I was wrong as the linkage problem didn't originate from the
aws crt library as I ori
lordgamez commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1163975274
##
extensions/aws/CMakeLists.txt:
##
Review Comment:
There isn't much documentation on this, most examples I found in other
repositories links all the r